Uh oh!
There was an error while loading. Please reload this page.
assert,util: harden comparison - #24831
Closed
BridgeAR wants to merge 4 commits into
Closed
Conversation
The former algorithm used checks which were unsafe. Most of these have been replaced with alternatives that can not be manipulated or fooled that easily.
BridgeAR
commented
Dec 5, 2018
MemberAuthor
@nodejs/assert @nodejs/util PTAL This needs some LGs. |
BridgeAR
commented
Dec 5, 2018
MemberAuthor
Trott
commented
Dec 5, 2018
Member
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19238/ |
BridgeAR
commented
Dec 5, 2018
MemberAuthor
Resumed build https://ci.nodejs.org/job/node-test-pull-request/19243/ |
Trott
commented
Dec 5, 2018
Member
addaleax
approved these changes
Dec 6, 2018
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-Authored-By: BridgeAR <ruben@bridgewater.de>
BridgeAR
commented
Dec 8, 2018
MemberAuthor
Member
If it helps, https://ci.nodejs.org/job/node-test-pull-request/19324/ is green. ✔️ |
ryzokuken
approved these changes
Dec 8, 2018
ryzokuken
left a comment
Contributor
There was a problem hiding this comment.
Looks really good to be overall. Will take a deeper look tomorrow or on Monday.
Trott
commented
Dec 10, 2018
Member
Landed in 9fb4fa8 |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 10, 2018
The former algorithm used checks which were unsafe. Most of these have been replaced with alternatives that can not be manipulated or fooled that easily. PR-URL: nodejs#24831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Dec 17, 2018
The former algorithm used checks which were unsafe. Most of these have been replaced with alternatives that can not be manipulated or fooled that easily. PR-URL: #24831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Merged
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
The former algorithm used checks which were unsafe. Most of these have been replaced with alternatives that can not be manipulated or fooled that easily. PR-URL: nodejs#24831 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The former algorithm used checks which were unsafe. Most of these
have been replaced with alternatives that can not be manipulated or
fooled that easily.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes