Skip to content

lib: extract validateObject validator - #24920

Closed
ZYSzys wants to merge 3 commits into
nodejs:masterfrom
zys-contrib:validate-object
Closed

lib: extract validateObject validator#24920
ZYSzys wants to merge 3 commits into
nodejs:masterfrom
zys-contrib:validate-object

Conversation

@ZYSzys

@ZYSzysZYSzys commented Dec 9, 2018

Copy link
Copy Markdown
Member

Pulls out the common argument validateObject validator to internal/validators.

BTW, there is inconsistent ERR_INVALID_ARG_TYPE via the object validation: object or Object, do we need to unify this error message ? Although this is so trivial :)

thrownewERR_INVALID_ARG_TYPE('pathObject','Object',pathObject);

thrownewERR_INVALID_ARG_TYPE('args','object',args);

Update: unify the error message by lowercase object(should be semver-major?)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. crypto Issues and PRs related to the crypto subsystem. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. labels Dec 9, 2018
Comment threadlib/trace_events.js Outdated
@mscdex

Copy link
Copy Markdown
Contributor

FWIW this conflicts with #24913

@ofrobotsofrobots removed the trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. label Feb 14, 2019
@ZYSzysZYSzys closed this Feb 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_processIssues and PRs related to the child_process subsystem.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ZYSzys@mscdex@BridgeAR@ofrobots@nodejs-github-bot