test: remove magic numbers in test-gc-http-client-onerror by Trott · Pull Request #24943 · nodejs/node

Trott · 2018-12-10T20:16:17Z

Remove magic numbers 500 and 10 from the test. Instead, detect when GC
has started and stop sending requests at that point.

On my laptop, this results in 68 or 72 requests per run instead of 500.

Fixes: #23089

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2018-12-10T20:16:19Z

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1886/pipeline

Trott · 2018-12-10T20:16:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19399/

Trott · 2018-12-10T20:20:11Z

Stress test on master (with -J --repeat 100) to hopefully reproduce failures: https://ci.nodejs.org/job/node-stress-single-test/2125/

Stress test on this PR with same parameters:
https://ci.nodejs.org/job/node-stress-single-test/2127/

bnoordhuis · 2018-12-10T21:48:39Z

Relevant failure: https://ci.nodejs.org/job/node-test-commit-linux/23914/nodes=centos6-64-gcc6/console

If I had to guess, it's because of the removal of the early return in getall().

Trott · 2018-12-10T22:12:00Z

Relevant failure:

Yeah, there's a few of those. Not sure how to re-implement an early return without restoring some kind of magic number but I'll think about it....

BridgeAR · 2018-12-12T14:44:31Z

@Trott it should be sufficient to add another variable (e.g., stop) which is set to true when the server ends. In that case getAll should stop being called.

Trott · 2018-12-13T05:14:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19473/

Trott · 2018-12-13T18:38:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19487/

Trott · 2018-12-13T21:45:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19492/

Remove magic numbers (500, 10, 100) from the test. Instead, detect when GC has started and stop sending requests at that point. On my laptop, this results in 16 or 20 requests per run instead of 500. Fixes: nodejs#23089

Trott · 2018-12-13T23:28:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19493/ ✔️

Trott · 2018-12-14T00:59:03Z

Worked out the puzzle. This works now. Could use some reviews!

Trott · 2018-12-15T04:08:59Z

Needs a review or two. /ping @nodejs/testing

Trott · 2018-12-16T17:14:17Z

Bump.

Trott · 2018-12-17T23:22:13Z

Landed in 47ecf20

Remove magic numbers (500, 10, 100) from the test. Instead, detect when GC has started and stop sending requests at that point. On my laptop, this results in 16 or 20 requests per run instead of 500. Fixes: nodejs#23089 PR-URL: nodejs#24943 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Remove magic numbers (500, 10, 100) from the test. Instead, detect when GC has started and stop sending requests at that point. On my laptop, this results in 16 or 20 requests per run instead of 500. Fixes: #23089 PR-URL: #24943 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Remove magic numbers (500, 10, 100) from the test. Instead, detect when GC has started and stop sending requests at that point. On my laptop, this results in 16 or 20 requests per run instead of 500. Fixes: nodejs#23089 PR-URL: nodejs#24943 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 10, 2018

Trott added the wip Issues and PRs that are still a work in progress. label Dec 10, 2018

Trott force-pushed the fix-23089 branch 2 times, most recently from 502e7a7 to aeb2138Compare December 13, 2018 05:14

Trott force-pushed the fix-23089 branch 2 times, most recently from 92b8899 to 011027aCompare December 13, 2018 18:38

Trott force-pushed the fix-23089 branch from 011027a to d37125eCompare December 13, 2018 21:44

test: remove magic numbers in test-gc-http-client-onerror
7974779
Remove magic numbers (500, 10, 100) from the test. Instead, detect when GC has started and stop sending requests at that point. On my laptop, this results in 16 or 20 requests per run instead of 500. Fixes: nodejs#23089

Trott force-pushed the fix-23089 branch from d37125e to 7974779Compare December 13, 2018 23:28

Trott removed the wip Issues and PRs that are still a work in progress. label Dec 14, 2018

cjihrig approved these changes Dec 16, 2018
View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 16, 2018

Trott closed this Dec 17, 2018

MylesBorins mentioned this pull request Dec 25, 2018
v10.15.0 proposal #25176
Merged

MylesBorins mentioned this pull request Dec 25, 2018
v11.6.0 proposal #25175
Merged

This was referenced Dec 26, 2018
2018-12-26 Version 10.15.0 'Dubnium' (LTS) @MylesBorins beevelop/docker-nodejs#254
Closed
2018-12-26 Version 10.15.0 'Dubnium' (LTS) @MylesBorins beevelop/docker-android-nodejs#276
Closed

Trott deleted the fix-23089 branch January 13, 2022 22:50

Uh oh!

Uh oh!

Conversation

Trott commented Dec 10, 2018

Checklist

Uh oh!

nodejs-github-bot commented Dec 10, 2018

Uh oh!

Trott commented Dec 10, 2018

Uh oh!

Trott commented Dec 10, 2018

Uh oh!

bnoordhuis commented Dec 10, 2018

Uh oh!

Trott commented Dec 10, 2018

Uh oh!

BridgeAR commented Dec 12, 2018

Uh oh!

Trott commented Dec 13, 2018

Uh oh!

Trott commented Dec 13, 2018

Uh oh!

Trott commented Dec 13, 2018

Uh oh!

Trott commented Dec 13, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Dec 14, 2018

Uh oh!

Trott commented Dec 15, 2018

Uh oh!

Trott commented Dec 16, 2018

Uh oh!

Trott commented Dec 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Trott commented Dec 13, 2018•
edited
Loading