Uh oh!
There was an error while loading. Please reload this page.
doc: corrected version http.createServer options addition - #25001
Closed
benswinburne wants to merge 1 commit into
Closed
doc: corrected version http.createServer options addition#25001benswinburne wants to merge 1 commit into
benswinburne wants to merge 1 commit into
Conversation
benswinburneforce-pushed
the
patch-1
branch
2 times, most recently
from
December 12, 2018 22:30
0fd86f0 to
413f652CompareContributor
Both versions should be documented as this feature was backported from v9.x to v8.x. |
benswinburne
commented
Dec 13, 2018
ContributorAuthor
Surely the documented version is since as opposed to a list of versions? If I am to list multiple, do you suggest it lists both in the same way. or explicitly note it was backported Perhaps you could suggest an example of another backported feature I can reference? |
Contributor
You can use comma-separated lists, like (newest versions first): - version: v9.6.0, v8.12.0That's how we're currently handling this in other parts of the documentation. |
8.12 Changelog https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md#8.12.0 Specifically [01dc646] - http: add options to http.createServer() nodejs#15752
lpinca
approved these changes
Feb 12, 2019
lpinca
commented
Mar 11, 2019
Member
@nodejs/documentation |
vsemozhetbyt
approved these changes
Mar 11, 2019
vsemozhetbyt
commented
Mar 11, 2019
Contributor
Landed in 9a39a65 |
BridgeAR pushed a commit
that referenced
this pull request
Mar 13, 2019
8.12 Changelog https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md#8.12.0 Specifically [01dc646] - http: add options to http.createServer() #15752 PR-URL: #25001 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Mar 14, 2019
8.12 Changelog https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md#8.12.0 Specifically [01dc646] - http: add options to http.createServer() #15752 PR-URL: #25001 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BethGriggs pushed a commit
that referenced
this pull request
Apr 16, 2019
8.12 Changelog https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md#8.12.0 Specifically [01dc646] - http: add options to http.createServer() #15752 PR-URL: #25001 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8.12 Changelog
https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V8.md#8.12.0
Specifically
[01dc646] - (SEMVER-MINOR) http: add options to http.createServer() (Peter Marton) #15752
Pull
#15752
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes