Uh oh!
There was an error while loading. Please reload this page.
[v10.x backport] test: move benchmark tests out of main test suite - #25049
Closed
Trott wants to merge 1 commit into
Closed
[v10.x backport] test: move benchmark tests out of main test suite#25049Trott wants to merge 1 commit into
Trott wants to merge 1 commit into
Conversation
Move benchmark tests (which are slow) out of the main test suite. We can hopefully add them to node-daily-master so that they are still run daily on CI. PR-URL: nodejs#24265 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Dec 14, 2018
MemberAuthor
2 tasks
Trott
commented
Dec 14, 2018
MemberAuthor
Trott
commented
Dec 14, 2018
MemberAuthor
The test-bootstrap-modules failure in CI is apparently a broken test on v10.x-staging. I don't know when the breakage was introduced or if the problem is in the test or core. See discussion in #25027. Anyway, unrelated to change here. But I imagine someone will want to track down what broke it on v10.x-staging? |
Member
Yeah i can try to dig into that; checks on the staging branch itself are green but i think it's just a basic test commit check which may have missed whatever failure is occurring? |
Trott
commented
Dec 17, 2018
MemberAuthor
@nodejs/backporters Any chance this can land? |
codebytere
commented
Dec 21, 2018
Member
could we rerun ci here? the commit to fix failing ci has been landed so we should be ✅ if we rebase |
MylesBorins pushed a commit
that referenced
this pull request
Dec 21, 2018
Move benchmark tests (which are slow) out of the main test suite. We can hopefully add them to node-daily-master so that they are still run daily on CI. Backport-PR-URL: #25049 PR-URL: #24265 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
commented
Dec 21, 2018
Contributor
As the busted test was a known regression I've gone ahead and landed in 5f649f6 |
MylesBorins pushed a commit
that referenced
this pull request
Dec 26, 2018
Move benchmark tests (which are slow) out of the main test suite. We can hopefully add them to node-daily-master so that they are still run daily on CI. Backport-PR-URL: #25049 PR-URL: #24265 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24265
Move benchmark tests (which are slow) out of the main test suite. We can
hopefully add them to node-daily-master so that they are still run daily
on CI.
PR-URL: #24265
Reviewed-By: Richard Lau riclau@uk.ibm.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Refael Ackermann refack@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes