Skip to content

test: exit sequence sanity tests - #25083

Merged
gireeshpunathil merged 1 commit into
nodejs:masterfrom
gireeshpunathil:exitrace1
Jan 29, 2019
Merged

test: exit sequence sanity tests#25083
gireeshpunathil merged 1 commit into
nodejs:masterfrom
gireeshpunathil:exitrace1

Conversation

@gireeshpunathil

@gireeshpunathilgireeshpunathil commented Dec 17, 2018

Copy link
Copy Markdown
Member

Execute many module loads in worker in a loop
while exiting from the main thread at arbitrary
execution points, and make sure that the workers
quiesce without crashing.

worker_threads are not necessarily the subject of
testing, those are used for easy simulation of
multi-thread scenarios.

Refs: #25007

The current code base is not yet ready to conceive this, so please don't land this before #25007 is fully resolved.

Checklist

@nodejs-github-bot

nodejs-github-bot commented Dec 17, 2018

Copy link
Copy Markdown
Collaborator

@gireeshpunathil build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1976/pipeline

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 17, 2018
@mscdexmscdex added the wip Issues and PRs that are still a work in progress. label Dec 17, 2018
@gireeshpunathilgireeshpunathil mentioned this pull request Dec 22, 2018
Closed
@gireeshpunathil

gireeshpunathil commented Jan 25, 2019

Copy link
Copy Markdown
MemberAuthor

given that #25061 is landed now, making first attempt in CI to see where we do stand. It passes in Linux locally, but I am interested in other platforms that have variations in thread inetractions.

CI: https://ci.nodejs.org/job/node-test-pull-request/20319/

@gireeshpunathil

gireeshpunathil commented Jan 25, 2019

Copy link
Copy Markdown
MemberAuthor

windows failure 08:28:59 not ok 497 parallel/test-trace-events-fs-sync is known through #25512

and arm failure 08:16:37 not ok 342 sequential/test-performance is known through #23291

@gireeshpunathilgireeshpunathil removed the wip Issues and PRs that are still a work in progress. label Jan 25, 2019
@gireeshpunathilgireeshpunathil changed the title [do not land] test: exit sequence sanity teststest: exit sequence sanity testsJan 25, 2019
addaleax
addaleax reviewed Jan 25, 2019
View reviewed changes
Comment threadtest/parallel/test-worker-cleanexit-with-moduleload.js Outdated
addaleax
addaleax approved these changes Jan 27, 2019
View reviewed changes
Comment threadtest/parallel/test-worker-cleanexit-with-moduleload.js Outdated
Trott
Trott reviewed Jan 27, 2019
View reviewed changes
Comment threadtest/parallel/test-worker-cleanexit-with-moduleload.js Outdated
@gireeshpunathil

gireeshpunathil commented Jan 29, 2019

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/20402/

@gireeshpunathilgireeshpunathil added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2019
@gireeshpunathil
test: exit sequence sanity tests
c3fd504
Execute many module loads in worker in a loop
while exiting from the main thread at arbitrary
execution points, and make sure that the workers
quiesce without crashing.
`worker_threads` are not necessarily the subject of
testing, those are used for easy simulation of
multi-thread scenarios.
Refs: nodejs#25007
PR-URL: nodejs#25083
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gireeshpunathil
gireeshpunathil merged commit c3fd504 into nodejs:masterJan 29, 2019
@gireeshpunathilgireeshpunathil removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 29, 2019
@gireeshpunathil

gireeshpunathil commented Jan 29, 2019

Copy link
Copy Markdown
MemberAuthor

landed as c3fd504

@gireeshpunathilgireeshpunathil mentioned this pull request Jan 29, 2019
Merged
3 tasks
targos pushed a commit that referenced this pull request Jan 29, 2019
@gireeshpunathil@targos
test: exit sequence sanity tests
ae19f94
Execute many module loads in worker in a loop
while exiting from the main thread at arbitrary
execution points, and make sure that the workers
quiesce without crashing.
`worker_threads` are not necessarily the subject of
testing, those are used for easy simulation of
multi-thread scenarios.
Refs: #25007
PR-URL: #25083
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Jan 29, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott left review comments
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gireeshpunathil@nodejs-github-bot@jasnell@Trott@addaleax@mscdex