Uh oh!
There was an error while loading. Please reload this page.
Update v8.x docs for http request set timeout - #25122
Closed
jbunton-atlassian wants to merge 1 commit into
Closed
Conversation
2 tasks
mscdex
commented
Dec 19, 2018
Contributor
I think you meant to target the v8.x-staging branch instead? |
jbunton-atlassianforce-pushed
the
update_v8.x_docs_for_http_request_setTimeout
branch
from
December 19, 2018 04:50
ff3bdc0 to
b1d62eeComparejbunton-atlassian
commented
Dec 19, 2018
ContributorAuthor
@mscdex so sorry! Indeed, I forgot to look at the diff 🤦♂️ |
mscdex
commented
Dec 19, 2018
Contributor
I'm not sure adding this is worthwhile. We already have changelogs with both commit info and high-level change information as well as important API changes across versions in the most recent docs. |
jbunton-atlassian
commented
Dec 19, 2018
ContributorAuthor
It took me a few hours to find this. The current documentation for v8.x is wrong which meant I actually only found the issue through a git-bisect. I was hoping to save others the same effort. |
mscdex
commented
Dec 19, 2018
Contributor
I see, I was mainly referring to the part about 'Note that this behaviour changes in Node.js version 9 and higher.' |
jbunton-atlassian
deleted the
update_v8.x_docs_for_http_request_setTimeout
branch
December 19, 2018 06:08
ContributorAuthor
Ack... I'm failing at git today. See #25123. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upgrading from Node.js 8 to 10 I hit the behaviour change in #8895. This documentation update would have helped me find the problem faster :)
Also see #25121 for an update to the docs on master.
Thanks :)
Checklist