Uh oh!
There was an error while loading. Please reload this page.
trace_events: move SetupTraceCategoryState into node_trace_events.cc - #25128
Closed
joyeecheung wants to merge 2 commits into
Closed
trace_events: move SetupTraceCategoryState into node_trace_events.cc#25128joyeecheung wants to merge 2 commits into
joyeecheung wants to merge 2 commits into
Conversation
It makes more sense to put it in `internalBinding('trace_events')`
instead of in the bootstrapper object.joyeecheung
commented
Dec 19, 2018
MemberAuthor
targos
reviewed
Dec 19, 2018
| const { traceCategoryState } = internalBinding('trace_events'); | ||
| const { | ||
| traceCategoryState, | ||
| setupTraceCategoryState |
Member
There was a problem hiding this comment.
Could you use another name (avoid that of the current executing function)?
joyeecheung
commented
Dec 19, 2018
MemberAuthor
@targos Thanks for catching that, I updated the internal function name to |
targos
approved these changes
Dec 19, 2018
richardlau
approved these changes
Dec 19, 2018
jasnell
approved these changes
Dec 19, 2018
joyeecheung
commented
Dec 20, 2018
MemberAuthor
joyeecheung
commented
Dec 21, 2018
MemberAuthor
joyeecheung added a commit
that referenced
this pull request
Dec 21, 2018
It makes more sense to put it in `internalBinding('trace_events')`
instead of in the bootstrapper object.
PR-URL: #25128
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>joyeecheung
commented
Dec 21, 2018
MemberAuthor
Landed in 70f2328, thanks! |
MylesBorins
commented
Dec 25, 2018
Contributor
This doesn't land cleanly on v11.x, should it be backported? |
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
It makes more sense to put it in `internalBinding('trace_events')`
instead of in the bootstrapper object.
PR-URL: nodejs#25128
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>addaleax
commented
Jan 14, 2019
Member
This applies cleanly now. |
addaleax pushed a commit
that referenced
this pull request
Jan 14, 2019
It makes more sense to put it in `internalBinding('trace_events')`
instead of in the bootstrapper object.
PR-URL: #25128
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com> Merged
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
It makes more sense to put it in `internalBinding('trace_events')`
instead of in the bootstrapper object.
PR-URL: nodejs#25128
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com> Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes more sense to put it in
internalBinding('trace_events')instead of in the bootstrapper object.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes