util: add null prototype support for date by antsmartian · Pull Request #25144 · nodejs/node

antsmartian · 2018-12-20T03:03:56Z

Adds the support of null prototype in Date object.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2018-12-20T03:03:58Z

@antsmartian build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2014/pipeline

BridgeAR

Since invalid dates will now be handled properly with keys as well, please also add a test for that (as well as subclassing if implemented).

antsmartian · 2018-12-21T02:44:15Z

@mscdex @BridgeAR PTAL...

antsmartian · 2018-12-21T03:27:07Z

~~CI : https://ci.nodejs.org/job/node-test-pull-request/19709/~~
CI : https://ci.nodejs.org/job/node-test-pull-request/19711/

BridgeAR

This is LG to me if the keys.length === 0 check is removed (the original conditional was a mistake in the first place and with the current implementation it produces a weird output).

BridgeAR

LGTM

antsmartian · 2018-12-21T12:39:15Z

Thanks for guiding me here @BridgeAR. I love utils, may be few more PR's on the way!

I guess we are now left with RE and Errors null proto handling. Will try out working on RE and send out a PR in a few days.

antsmartian · 2018-12-21T12:52:30Z

CI : https://ci.nodejs.org/job/node-test-pull-request/19714/

jdalton · 2018-12-21T21:51:38Z

I've had this bite me for other non-date values. Might be a good time to review other places this can happen.

antsmartian · 2018-12-22T05:07:36Z

@jdalton Yes. We have already support for other types apart from Error and RE.

antsmartian · 2018-12-22T10:28:05Z

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19748/ ✔️

BridgeAR · 2018-12-27T21:42:44Z

@nodejs/util this could use another LG.

@antsmartian this needs a rebase.

antsmartian · 2019-01-07T15:49:28Z

New CI After Rebase: https://ci.nodejs.org/job/node-test-pull-request/19966/

antsmartian · 2019-01-08T02:04:51Z

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/19986/

antsmartian · 2019-01-09T02:03:48Z

Fresh CI (after rebase due to conflict): https://ci.nodejs.org/job/node-test-pull-request/20009/

antsmartian · 2019-01-09T13:09:32Z

@BridgeAR @jasnell Rebased the codebase, do you want to have a look once before I land this? I'm planning to land it soon.

antsmartian · 2019-01-09T14:00:09Z

CI : https://ci.nodejs.org/job/node-test-pull-request/20020/

BridgeAR · 2019-01-10T02:25:06Z

Landed in 81b25ea 🎉

PR-URL: nodejs#25144 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #25144 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#25144 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Dec 20, 2018

antsmartian force-pushed the date_util branch from 24a5949 to 06e565bCompare December 20, 2018 03:05

antsmartian mentioned this pull request Dec 20, 2018
Setting null prototype to Date object results error #25145
Closed

BridgeAR reviewed Dec 20, 2018
View reviewed changes

Comment threadlib/internal/util/inspect.js Outdated
Comment threadtest/parallel/test-util-inspect.js Outdated

mscdex reviewed Dec 20, 2018
View reviewed changes

Comment threadlib/internal/util/inspect.js Outdated

antsmartian force-pushed the date_util branch 2 times, most recently from 43c8edf to 435415fCompare December 21, 2018 02:43

antsmartian force-pushed the date_util branch 2 times, most recently from 2a9c063 to 5f8d3a9Compare December 21, 2018 11:06

BridgeAR reviewed Dec 21, 2018
View reviewed changes

Comment threadlib/internal/util/inspect.js Outdated

antsmartian force-pushed the date_util branch from 5f8d3a9 to 556713eCompare December 21, 2018 12:16

BridgeAR reviewed Dec 21, 2018
View reviewed changes

Comment threadtest/parallel/test-util-inspect.js Outdated

antsmartian force-pushed the date_util branch 2 times, most recently from 840315d to 58b2abaCompare December 21, 2018 12:33

BridgeAR approved these changes Dec 21, 2018
View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 22, 2018

addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 31, 2018

antsmartian force-pushed the date_util branch from 58b2aba to b0ecc9cCompare January 7, 2019 14:57

jasnell approved these changes Jan 8, 2019
View reviewed changes

antsmartian force-pushed the date_util branch from b0ecc9c to 7ffa189Compare January 9, 2019 02:02

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 9, 2019

BridgeAR reviewed Jan 9, 2019
View reviewed changes

Comment threadtest/parallel/test-util-inspect.js Outdated

util: add null prototype support for date
a5ea84a

antsmartian force-pushed the date_util branch from 7ffa189 to a5ea84aCompare January 9, 2019 13:23

BridgeAR closed this Jan 10, 2019

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 10, 2019
util: add null prototype support for date
81b25ea
PR-URL: nodejs#25144 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

antsmartian deleted the date_util branch January 10, 2019 02:49

addaleax pushed a commit that referenced this pull request Jan 14, 2019
util: add null prototype support for date
2e6e4cf
PR-URL: #25144 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR mentioned this pull request Jan 16, 2019
v11.7.0 proposal #25537
Merged

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
util: add null prototype support for date
7dab908
PR-URL: nodejs#25144 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins mentioned this pull request Jan 24, 2019
v11.8.0 proposal #25687
Merged

Uh oh!

Uh oh!

Conversation

antsmartian commented Dec 20, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Dec 20, 2018

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antsmartian commented Dec 21, 2018

Uh oh!

antsmartian commented Dec 21, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

antsmartian commented Dec 21, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antsmartian commented Dec 21, 2018

Uh oh!

jdalton commented Dec 21, 2018

Uh oh!

antsmartian commented Dec 22, 2018

Uh oh!

antsmartian commented Dec 22, 2018• edited by Trott Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR commented Dec 27, 2018

Uh oh!

antsmartian commented Jan 7, 2019

Uh oh!

antsmartian commented Jan 8, 2019

Uh oh!

antsmartian commented Jan 9, 2019

Uh oh!

antsmartian commented Jan 9, 2019

Uh oh!

Uh oh!

antsmartian commented Jan 9, 2019

Uh oh!

BridgeAR commented Jan 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

antsmartian commented Dec 20, 2018•
edited
Loading

antsmartian commented Dec 21, 2018•
edited
Loading

antsmartian commented Dec 21, 2018•
edited
Loading

antsmartian commented Dec 22, 2018•
edited by Trott
Loading