Uh oh!
There was an error while loading. Please reload this page.
v6.16.0 proposal - #25178
Merged
Merged
Conversation
This commit adds http_parser_set_max_header_size() to the http-parser for overriding the compile time maximum HTTP header size. Backport-PR-URL: #25173 PR-URL: #24811Fixes: #24692 Refs: nodejs/http-parser#453 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Allow the maximum size of HTTP headers to be overridden from the command line. Backport-PR-URL: #25173 co-authored-by: Matteo Collina <hello@matteocollina.com> PR-URL: #24811Fixes: #24692 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorinsforce-pushed
the
v6.16.0-proposal
branch
from
December 21, 2018 23:49
854cd50 to
a7b8adaCompareMylesBorinsforce-pushed
the
v6.16.0-proposal
branch
from
December 21, 2018 23:49
a7b8ada to
841c3eaCompareMylesBorins added a commit
that referenced
this pull request
Dec 21, 2018
The 6.15.0 security release introduced some unexpected breakages on the 6.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 PR-URL: #25178
MylesBorins
commented
Dec 21, 2018
ContributorAuthor
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
MylesBorinsforce-pushed
the
v6.16.0-proposal
branch
from
December 22, 2018 04:44
841c3ea to
5c2566cCompareMylesBorins added a commit
that referenced
this pull request
Dec 22, 2018
The 6.15.0 security release introduced some unexpected breakages on the 6.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 PR-URL: #25178
ContributorAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/19741/ ✅ |
cjihrig
approved these changes
Dec 22, 2018
This commit exposes the value of --max-http-header-size as a property of the http module. Backport-PR-URL: #25218 PR-URL: #24860 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorinsforce-pushed
the
v6.16.0-proposal
branch
from
December 25, 2018 15:15
5c2566c to
50eb985CompareContributorAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/19807/ ✅ |
The 6.15.0 security release introduced some unexpected breakages on the 6.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 * http: - add maxHeaderSize property (cjihrig) #24860 PR-URL: #25178
MylesBorinsforce-pushed
the
v6.16.0-proposal
branch
from
December 25, 2018 18:09
50eb985 to
a3aa4b4CompareMylesBorins added a commit
that referenced
this pull request
Dec 26, 2018
The 6.15.0 security release introduced some unexpected breakages on the 6.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable changes: * cli: - add --max-http-header-size flag (cjihrig) #24811 * http: - add maxHeaderSize property (cjihrig) #24860 PR-URL: #25178
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
The 6.15.0 security release introduced some unexpected breakages on the 6.x release line. This is a special release to fix a regression in the HTTP binary upgrade response body and add a missing CLI flag to adjust the max header size of the http parser. Notable changes: * cli: - add --max-http-header-size flag (cjihrig) nodejs#24811 * http: - add maxHeaderSize property (cjihrig) nodejs#24860 PR-URL: nodejs#25178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2018-12-26, Version 6.16.0 'Boron' (LTS), @MylesBorins
The 6.15.0 security release introduced some unexpected breakages on the 6.x release line.
This is a special release to fix a regression in the HTTP binary upgrade response body and add
a missing CLI flag to adjust the max header size of the http parser.
Notable Changes
Commits
f233b160c9] - (SEMVER-MINOR)cli: add --max-http-header-size flag (cjihrig) #2481159f83d6896] - (SEMVER-MINOR)deps: cherry-pick http_parser_set_max_header_size (cjihrig) #24811c0c4de71f0] - (SEMVER-MINOR)http: add maxHeaderSize property (cjihrig) #248608a3e0c0697] - http: fix regression of binary upgrade response body (Matteo Collina) #25036