Uh oh!
There was an error while loading. Please reload this page.
util: cleanup util - #25255
Closed
BridgeAR wants to merge 5 commits into
Closed
Conversation
This makes sure the counter goes up instead of going down. This allows to properly track the current inspection depth no matter what the `depth` option was set to.
Remove some dead code plus some minor refactoring for readability. The constructor can not be an empty string anymore, so just remove that check.
This removes a special casing for this data type in the main function.
This comment is not correct anymore.
This should improve the readability of the code.
BridgeAR
commented
Jan 9, 2019
MemberAuthor
@nodejs/util PTAL This is open for quite some while without getting any reviews. |
jasnell
approved these changes
Jan 9, 2019
BridgeAR
commented
Jan 9, 2019
MemberAuthor
BridgeAR
commented
Jan 10, 2019
MemberAuthor
danbev pushed a commit
that referenced
this pull request
Jan 11, 2019
This makes sure the counter goes up instead of going down. This allows to properly track the current inspection depth no matter what the `depth` option was set to. PR-URL: #25255 Reviewed-By: James M Snell <jasnell@gmail.com>
danbev pushed a commit
that referenced
this pull request
Jan 11, 2019
Remove some dead code plus some minor refactoring for readability. The constructor can not be an empty string anymore, so just remove that check. PR-URL: #25255 Reviewed-By: James M Snell <jasnell@gmail.com>
danbev pushed a commit
that referenced
this pull request
Jan 11, 2019
This removes a special casing for this data type in the main function. PR-URL: #25255 Reviewed-By: James M Snell <jasnell@gmail.com>
danbev pushed a commit
that referenced
this pull request
Jan 11, 2019
This comment is not correct anymore. PR-URL: #25255 Reviewed-By: James M Snell <jasnell@gmail.com>
danbev pushed a commit
that referenced
this pull request
Jan 11, 2019
This should improve the readability of the code. PR-URL: #25255 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Jan 14, 2019
This makes sure the counter goes up instead of going down. This allows to properly track the current inspection depth no matter what the `depth` option was set to. PR-URL: #25255 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Jan 14, 2019
Remove some dead code plus some minor refactoring for readability. The constructor can not be an empty string anymore, so just remove that check. PR-URL: #25255 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Jan 14, 2019
This removes a special casing for this data type in the main function. PR-URL: #25255 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Jan 14, 2019
This comment is not correct anymore. PR-URL: #25255 Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Jan 14, 2019
This should improve the readability of the code. PR-URL: #25255 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
This makes sure the counter goes up instead of going down. This allows to properly track the current inspection depth no matter what the `depth` option was set to. PR-URL: nodejs#25255 Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
Remove some dead code plus some minor refactoring for readability. The constructor can not be an empty string anymore, so just remove that check. PR-URL: nodejs#25255 Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
This removes a special casing for this data type in the main function. PR-URL: nodejs#25255 Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
This comment is not correct anymore. PR-URL: nodejs#25255 Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
This should improve the readability of the code. PR-URL: nodejs#25255 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some cleanup while trying to figure out some other things.
Please have a look at the commit messages for details.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes