Uh oh!
There was an error while loading. Please reload this page.
lib/buffer: change checks for SlowBuffer creation - #25266
Closed
Mnwa wants to merge 2 commits into
Closed
Conversation
lib/buffer: change var to let/const variables initialization
Trott
commented
Dec 29, 2018
Member
(You can read about how to run benchmarks locally in the README file in the benchmark directory and in writing-and-running-benchmarks.md in the doc/guides directory.) |
Member
I tried to launch a job on CI to compare benchmarks but the build failed. @nodejs/build https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks-compare/18/ Details++ git checkout masterAlready on 'master'Your branch is up-to-date with 'origin/master'.++ ./configure++ make -j88In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationtailoring.cpp:24:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationsettings.cpp:21:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationdata.cpp:23:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^../deps/icu-small/source/i18n/olsontz.cpp: In member function ‘virtual UBool icu_63::OlsonTimeZone::inDaylightTime(UDate, UErrorCode&) const’:../deps/icu-small/source/i18n/olsontz.cpp:604:18: warning: ‘dst’ may be used uninitialized in this function [-Wmaybe-uninitialized] int32_t raw, dst; ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/coleitr.cpp:38:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/coll.cpp:51:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/utf16collationiterator.cpp:21:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationdatawriter.cpp:22:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationiterator.cpp:25:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationbuilder.cpp:37:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^../deps/icu-small/source/i18n/collationweights.cpp: In member function ‘UBool icu_63::CollationWeights::allocWeights(uint32_t, uint32_t, int32_t)’:../deps/icu-small/source/i18n/collationweights.cpp:497:1: warning: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Wstrict-overflow] CollationWeights::allocWeights(uint32_t lowerLimit, uint32_t upperLimit, int32_t n) { ^../deps/icu-small/source/i18n/collationweights.cpp:394:39: warning: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Wstrict-overflow] for(int32_t i = 0; i < rangeCount && ranges[i].length <= (minLength + 1); ++i) { ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationiterator.h:23, from ../deps/icu-small/source/i18n/collationcompare.cpp:22:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationdatareader.cpp:23:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/usearch.cpp:20:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationiterator.h:23, from ../deps/icu-small/source/i18n/collationkeys.cpp:20:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationsets.cpp:23:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^../deps/icu-small/source/i18n/listformatter.cpp: In member function ‘icu_63::UnicodeString& icu_63::ListFormatter::format_(const icu_63::UnicodeString*, int32_t, icu_63::UnicodeString&, int32_t, int32_t&, icu_63::FieldPositionHandler*, UErrorCode&) const’:../deps/icu-small/source/i18n/listformatter.cpp:449:35: warning: ‘offsetSecond’ may be used uninitialized in this function [-Wmaybe-uninitialized] offsets[1] = offsetSecond - prefixLength; ^../deps/icu-small/source/i18n/listformatter.cpp:449:35: warning: ‘offsetFirst’ may be used uninitialized in this function [-Wmaybe-uninitialized]../deps/icu-small/source/i18n/listformatter.cpp: In member function ‘icu_63::UnicodeString& icu_63::ListFormatter::format(const icu_63::UnicodeString*, int32_t, icu_63::UnicodeString&, icu_63::FieldPositionIterator*, UErrorCode&) const’:../deps/icu-small/source/i18n/listformatter.cpp:449:35: warning: ‘offsetSecond’ may be used uninitialized in this function [-Wmaybe-uninitialized]../deps/icu-small/source/i18n/listformatter.cpp:431:13: note: ‘offsetSecond’ was declared here int32_t offsetSecond; ^../deps/icu-small/source/i18n/listformatter.cpp:449:35: warning: ‘offsetFirst’ may be used uninitialized in this function [-Wmaybe-uninitialized] offsets[1] = offsetSecond - prefixLength; ^../deps/icu-small/source/i18n/listformatter.cpp:430:13: note: ‘offsetFirst’ was declared here int32_t offsetFirst; ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/utf8collationiterator.cpp:22:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/uitercollationiterator.cpp:22:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationruleparser.cpp:30:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationroot.cpp:21:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationfastlatin.cpp:19:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationfastlatinbuilder.cpp:31:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/rulebasedcollator.cpp:39:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationdatabuilder.cpp:30:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^../deps/nghttp2/lib/nghttp2_helper.c: In function ‘nghttp2_put_uint16be’:../deps/nghttp2/lib/nghttp2_helper.c:33:16: warning: implicit declaration of function ‘htons’ [-Wimplicit-function-declaration] uint16_t x = htons(n); ^../deps/nghttp2/lib/nghttp2_helper.c: In function ‘nghttp2_put_uint32be’:../deps/nghttp2/lib/nghttp2_helper.c:38:16: warning: implicit declaration of function ‘htonl’ [-Wimplicit-function-declaration] uint32_t x = htonl(n); ^../deps/nghttp2/lib/nghttp2_helper.c: In function ‘nghttp2_get_uint16’:../deps/nghttp2/lib/nghttp2_helper.c:45:10: warning: implicit declaration of function ‘ntohs’ [-Wimplicit-function-declaration] return ntohs(n); ^../deps/nghttp2/lib/nghttp2_helper.c: In function ‘nghttp2_get_uint32’:../deps/nghttp2/lib/nghttp2_helper.c:51:10: warning: implicit declaration of function ‘ntohl’ [-Wimplicit-function-declaration] return ntohl(n); ^In file included from ../deps/icu-small/source/common/characterproperties.cpp:18:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/unorm.cpp:37:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/caniter.cpp:23:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/unormcmp.cpp:30:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/norm2allmodes.h:26:0, from ../deps/icu-small/source/common/loadednormalizer2impl.cpp:26:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/uniset_props.cpp:38:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/normlzr.cpp:23:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/norm2allmodes.h:26:0, from ../deps/icu-small/source/common/normalizer2.cpp:30:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^../deps/icu-small/source/common/ucptrie.cpp: In function ‘UChar32 {anonymous}::getRange(const void*, UChar32, uint32_t (*)(const void*, uint32_t), const void*, uint32_t*)’:../deps/icu-small/source/common/ucptrie.cpp:393:5: warning: ‘value’ may be used uninitialized in this function [-Wmaybe-uninitialized] if (maybeFilterValue(highValue, trie->nullValue, nullValue, ^In file included from ../deps/icu-small/source/common/uprops.cpp:33:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/tools/toolutil/collationinfo.cpp:21:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^../deps/icu-small/source/tools/toolutil/ucmstate.cpp: In function ‘void compactToUnicode2(UCMStates*, uint16_t**, _MBCSToUFallback*, int32_t, UBool)’:../deps/icu-small/source/tools/toolutil/ucmstate.cpp:656:53: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if(MBCS_ENTRY_IS_TRANSITION(entry) && (MBCS_ENTRY_TRANSITION_STATE(entry))==trailState) { ^In file included from ../deps/icu-small/source/tools/toolutil/swapimpl.cpp:55:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/characterproperties.cpp:18:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/norm2allmodes.h:26:0, from ../deps/icu-small/source/common/loadednormalizer2impl.cpp:26:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/caniter.cpp:23:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/unorm.cpp:37:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/unormcmp.cpp:30:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/normalizer2impl.cpp:38:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^../deps/icu-small/source/common/unistr.cpp:1976:13: warning: ‘void uprv_UnicodeStringDummy()’ defined but not used [-Wunused-function] static void uprv_UnicodeStringDummy(void) { ^In file included from ../deps/icu-small/source/common/uniset_props.cpp:38:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^../deps/icu-small/source/common/ucptrie.cpp: In function ‘UChar32 {anonymous}::getRange(const void*, UChar32, uint32_t (*)(const void*, uint32_t), const void*, uint32_t*)’:../deps/icu-small/source/common/ucptrie.cpp:393:5: warning: ‘value’ may be used uninitialized in this function [-Wmaybe-uninitialized] if (maybeFilterValue(highValue, trie->nullValue, nullValue, ^In file included from ../deps/icu-small/source/common/normlzr.cpp:23:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/uprops.cpp:33:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/norm2allmodes.h:26:0, from ../deps/icu-small/source/common/normalizer2.cpp:30:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationtailoring.cpp:24:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationsettings.cpp:21:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationdata.cpp:23:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/coleitr.cpp:38:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^../deps/icu-small/source/i18n/olsontz.cpp: In member function ‘virtual UBool icu_63::OlsonTimeZone::inDaylightTime(UDate, UErrorCode&) const’:../deps/icu-small/source/i18n/olsontz.cpp:604:18: warning: ‘dst’ may be used uninitialized in this function [-Wmaybe-uninitialized] int32_t raw, dst; ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/coll.cpp:51:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationdatawriter.cpp:22:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/utf16collationiterator.cpp:21:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationiterator.cpp:25:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationiterator.h:23, from ../deps/icu-small/source/i18n/collationcompare.cpp:22:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/common/normalizer2impl.cpp:38:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationbuilder.cpp:37:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^../deps/icu-small/source/i18n/collationweights.cpp: In member function ‘UBool icu_63::CollationWeights::allocWeights(uint32_t, uint32_t, int32_t)’:../deps/icu-small/source/i18n/collationweights.cpp:497:1: warning: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Wstrict-overflow] CollationWeights::allocWeights(uint32_t lowerLimit, uint32_t upperLimit, int32_t n) { ^../deps/icu-small/source/i18n/collationweights.cpp:394:39: warning: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Wstrict-overflow] for(int32_t i = 0; i < rangeCount && ranges[i].length <= (minLength + 1); ++i) { ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationiterator.h:23, from ../deps/icu-small/source/i18n/collationkeys.cpp:20:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationdatareader.cpp:23:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/uitercollationiterator.cpp:22:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationsets.cpp:23:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/utf8collationiterator.cpp:22:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^../deps/icu-small/source/i18n/listformatter.cpp: In member function ‘icu_63::UnicodeString& icu_63::ListFormatter::format_(const icu_63::UnicodeString*, int32_t, icu_63::UnicodeString&, int32_t, int32_t&, icu_63::FieldPositionHandler*, UErrorCode&) const’:../deps/icu-small/source/i18n/listformatter.cpp:449:35: warning: ‘offsetSecond’ may be used uninitialized in this function [-Wmaybe-uninitialized] offsets[1] = offsetSecond - prefixLength; ^../deps/icu-small/source/i18n/listformatter.cpp:449:35: warning: ‘offsetFirst’ may be used uninitialized in this function [-Wmaybe-uninitialized]../deps/icu-small/source/i18n/listformatter.cpp: In member function ‘icu_63::UnicodeString& icu_63::ListFormatter::format(const icu_63::UnicodeString*, int32_t, icu_63::UnicodeString&, icu_63::FieldPositionIterator*, UErrorCode&) const’:../deps/icu-small/source/i18n/listformatter.cpp:449:35: warning: ‘offsetSecond’ may be used uninitialized in this function [-Wmaybe-uninitialized]../deps/icu-small/source/i18n/listformatter.cpp:431:13: note: ‘offsetSecond’ was declared here int32_t offsetSecond; ^../deps/icu-small/source/i18n/listformatter.cpp:449:35: warning: ‘offsetFirst’ may be used uninitialized in this function [-Wmaybe-uninitialized] offsets[1] = offsetSecond - prefixLength; ^../deps/icu-small/source/i18n/listformatter.cpp:430:13: note: ‘offsetFirst’ was declared here int32_t offsetFirst; ^../deps/icu-small/source/common/unistr.cpp:1976:13: warning: ‘void uprv_UnicodeStringDummy()’ defined but not used [-Wunused-function] static void uprv_UnicodeStringDummy(void) { ^In file included from ../deps/icu-small/source/i18n/usearch.cpp:20:0:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^make[1]: execvp: printf: Argument list too longmake[1]: *** [/home/iojs/build/workspace/benchmark-node-micro-benchmarks-compare/benchmarking/experimental/benchmarks/community-benchmark/node/out/Release/obj.target/deps/openssl/libopenssl.a] Error 127make[1]: *** Waiting for unfinished jobs....In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationruleparser.cpp:30:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationroot.cpp:21:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationfastlatinbuilder.cpp:31:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationfastlatin.cpp:19:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/collationdatabuilder.cpp:30:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^In file included from ../deps/icu-small/source/i18n/collationdata.h:24:0, from ../deps/icu-small/source/i18n/rulebasedcollator.cpp:39:../deps/icu-small/source/common/normalizer2impl.h: In member function ‘uint16_t icu_63::Normalizer2Impl::getNorm16(UChar32) const’:../deps/icu-small/source/common/normalizer2impl.h:267:43: warning: enumeral and non-enumeral type in conditional expression [-Wextra] return U_IS_LEAD(c) ? INERT : UCPTRIE_FAST_GET(normTrie, UCPTRIE_16, c); ^make: *** [node] Error 2Build step 'Execute shell' marked build as failureSending e-mails to: gareth@gsellis.comNotifying upstream projects of job completionFinished: FAILURE |
ContributorAuthor
Hi, @Trott! Hmm, I'm didn't change C code, it's must build success. Thanks for you answer! I will check it and try to run bench locally PS. When I run tests - build was successful |
Trott
commented
Dec 29, 2018
Member
Yes, I don't think your changes broke the Jenkins job. I think the Jenkins job was already broken. :-( |
Mnwa
commented
Dec 30, 2018
ContributorAuthor
I was update pr with one commit whats make benchs faster and soon make bench tests locally |
addaleax
approved these changes
Dec 30, 2018
Mnwa
commented
Jan 1, 2019
ContributorAuthor
Hi @Trott! Buffer bench tests run 15 hours and had done only 20 tests from 27 |
Trott
commented
Jan 2, 2019
Member
Re-pinging @nodejs/build now that the New Year's holiday is mostly/nearly passed: Does anyone know if I'm doing something wrong on the benchmark job? Or if it just happens to be broken right now and it's not something I'm doing? Would be good if @Mnwa didn't have to run 15+ hours of benchmarks on their own machine (although I'm grateful that they're doing all that). |
Mnwa
commented
Jan 3, 2019
ContributorAuthor
@Trott what happened with bench tests again? My locally buffer test is run 30 hours :) |
Trott
commented
Jan 4, 2019
Member
I tried asking in IRC. If that doesn't work, I'll bring it up at the next Build meeting. |
jasnell
approved these changes
Jan 4, 2019
Mnwa
commented
Jan 4, 2019
ContributorAuthor
Ok, I will wait, may be my locally bench will end earlier :D |
Mnwa
commented
Jan 5, 2019
ContributorAuthor
@Trott I don't end full buffer bench tests, they ended on buffer swap tests. But there's no big difference on completed benchs
|
Trott
commented
Jan 5, 2019
Member
Thanks for doing the benchmarks. I'm sure that was not exactly fun. The most significant change is a positive one, so that's good: buffers/buffer-fill.js n=20000 size=8192 type='fill("test")' *** 6.64 % ±3.56% ±4.75% ±6.20% |
Member
Mnwa
commented
Jan 5, 2019
ContributorAuthor
Nice! Hope you will merge it! :D |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Jan 6, 2019
PR-URL: nodejs#25266 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Jan 6, 2019
Member
Landed in 728505a. Thanks for the contribution! 🎉 |
Mnwa
commented
Jan 6, 2019
ContributorAuthor
Thanks! |
addaleax pushed a commit
that referenced
this pull request
Jan 9, 2019
PR-URL: #25266 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#25266 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
PR-URL: nodejs#25266 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/buffer: fix unused variable initialization in SlowBuffer method
lib/buffer: change var to let/const variables initialization
make -j4 test(UNIX), orvcbuild test(Windows) passes