Skip to content

test: mark test-util-callbackify flaky on AIX - #25284

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:flaky-callbackify
Closed

test: mark test-util-callbackify flaky on AIX#25284
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:flaky-callbackify

Conversation

@Trott

@TrottTrott commented Dec 30, 2018

Copy link
Copy Markdown
Member

Refs: #25068

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@TrottTrott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Dec 30, 2018
@nodejs-github-bot

nodejs-github-bot commented Dec 30, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2112/pipeline

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 30, 2018
@Trott

Trott commented Dec 30, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/19866/ ✅

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 31, 2018
@Trott

Trott commented Jan 2, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 5fab50b

@TrottTrott closed this Jan 2, 2019
Trott added a commit to Trott/io.js that referenced this pull request Jan 2, 2019
@Trott
test: mark test-util-callbackify flaky on AIX
5fab50b
Refs: nodejs#25068
PR-URL: nodejs#25284
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 5, 2019
@Trott@addaleax
test: mark test-util-callbackify flaky on AIX
61fc3bf
Refs: #25068
PR-URL: #25284
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott@refack
test: mark test-util-callbackify flaky on AIX
fddd07f
Refs: nodejs#25068
PR-URL: nodejs#25284
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@Trott@BridgeAR
test: mark test-util-callbackify flaky on AIX
477185c
Refs: nodejs#25068
PR-URL: nodejs#25284
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@Trott@BethGriggs
test: mark test-util-callbackify flaky on AIX
07724fe
Refs: #25068
PR-URL: #25284
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@Trott@BethGriggs
test: mark test-util-callbackify flaky on AIX
2987c96
Refs: #25068
PR-URL: #25284
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@Trott@MylesBorins
test: mark test-util-callbackify flaky on AIX
5095d6c
Refs: #25068
PR-URL: #25284
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@Trott
Trott deleted the flaky-callbackify branch January 13, 2022 22:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.flaky-testIssues and PRs related to the tests with unstable failures on the CI.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Trott@nodejs-github-bot@jasnell@lpinca@cjihrig