Uh oh!
There was an error while loading. Please reload this page.
test: remove flag for test-addon-uv-handle-leak - #25327
Closed
Trott wants to merge 1 commit into
Closed
Conversation
test-addon-uv-handle-leak only requires worker_threads for the subprocess which it explicitly calls with --experimental-worker. The main test itself does not need it. Remove Flags: comment and move loading of worker_threads into subprocess-only logic.
MemberAuthor
cjihrig
approved these changes
Jan 3, 2019
lpinca
approved these changes
Jan 3, 2019
watilde
approved these changes
Jan 4, 2019
jasnell
approved these changes
Jan 4, 2019
Trott
commented
Jan 6, 2019
MemberAuthor
Landed in 7ed790e |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jan 6, 2019
test-addon-uv-handle-leak only requires worker_threads for the subprocess which it explicitly calls with --experimental-worker. The main test itself does not need it. Remove Flags: comment and move loading of worker_threads into subprocess-only logic. PR-URL: nodejs#25327 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Jan 9, 2019
test-addon-uv-handle-leak only requires worker_threads for the subprocess which it explicitly calls with --experimental-worker. The main test itself does not need it. Remove Flags: comment and move loading of worker_threads into subprocess-only logic. PR-URL: #25327 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
test-addon-uv-handle-leak only requires worker_threads for the subprocess which it explicitly calls with --experimental-worker. The main test itself does not need it. Remove Flags: comment and move loading of worker_threads into subprocess-only logic. PR-URL: nodejs#25327 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
test-addon-uv-handle-leak only requires worker_threads for the subprocess which it explicitly calls with --experimental-worker. The main test itself does not need it. Remove Flags: comment and move loading of worker_threads into subprocess-only logic. PR-URL: nodejs#25327 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-addon-uv-handle-leak only requires worker_threads for the
subprocess which it explicitly calls with --experimental-worker. The
main test itself does not need it. Remove Flags: comment and move
loading of worker_threads into subprocess-only logic.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes