Skip to content

doc: clarify timing of socket.connecting - #25333

Closed
sam-github wants to merge 1 commit into
masterfrom
clarify-socket-connecting
Closed

doc: clarify timing of socket.connecting#25333
sam-github wants to merge 1 commit into
masterfrom
clarify-socket-connecting

Conversation

@sam-github

@sam-githubsam-github commented Jan 4, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Jan 4, 2019

Copy link
Copy Markdown
Collaborator

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2135/pipeline

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Jan 4, 2019
@sam-githubsam-github mentioned this pull request Jan 4, 2019
Closed
lpinca
lpinca reviewed Jan 4, 2019
View reviewed changes
Comment threaddoc/api/net.md Outdated
vsemozhetbyt
vsemozhetbyt reviewed Jan 4, 2019
View reviewed changes
Comment threaddoc/api/net.md Outdated
@sam-github

sam-github commented Jan 4, 2019

Copy link
Copy Markdown
ContributorAuthor

Removed the "Fixes", since it aparently does not. Still, I think its a small doc improvement, as its a bit more clear.

@sam-github

sam-github commented Jan 7, 2019

Copy link
Copy Markdown
ContributorAuthor

ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2162/ (GREEN)

addaleax
addaleax approved these changes Jan 8, 2019
View reviewed changes
Comment threaddoc/api/net.md Outdated
Comment threaddoc/api/net.md Outdated
Comment threaddoc/api/net.md Outdated
@sam-github

sam-github commented Jan 8, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

ci-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2188/

@sam-github
sam-githubforce-pushed the clarify-socket-connecting branch from 464ca30 to 4e2b920CompareJanuary 8, 2019 18:50
@sam-github

sam-github commented Jan 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Landed in ccc06a3

@sam-github
sam-github deleted the clarify-socket-connecting branch January 9, 2019 03:55
sam-github added a commit that referenced this pull request Jan 9, 2019
@sam-github
doc: clarify timing of socket.connecting
ccc06a3
Fixes: #25328
PR-URL: #25333
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@sam-github@addaleax
doc: clarify timing of socket.connecting
f3d8639
Fixes: #25328
PR-URL: #25333
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeARBridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@sam-github@BridgeAR
doc: clarify timing of socket.connecting
4bc2a4f
Fixes: nodejs#25328
PR-URL: nodejs#25333
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@sam-github@BethGriggs
doc: clarify timing of socket.connecting
f84317f
Fixes: #25328
PR-URL: #25333
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@sam-github@BethGriggs
doc: clarify timing of socket.connecting
769736c
Fixes: #25328
PR-URL: #25333
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@sam-github@MylesBorins
doc: clarify timing of socket.connecting
ce3cf0d
Fixes: #25328
PR-URL: #25333
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced May 29, 2019
Closed
Closed
This was referenced May 29, 2019
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes
+1 more reviewer
@vsemozhetbytvsemozhetbytvsemozhetbyt left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.netIssues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sam-github@nodejs-github-bot@jasnell@addaleax@lpinca@cjihrig@BethGriggs@vsemozhetbyt