Uh oh!
There was an error while loading. Please reload this page.
test: improve test coverage of native crypto code - #25400
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
cjihrig
approved these changes
Jan 8, 2019
sam-github
approved these changes
Jan 8, 2019
lpinca
approved these changes
Jan 8, 2019
danbev
commented
Jan 9, 2019
Contributor
jasnell
approved these changes
Jan 9, 2019
tniessen
commented
Jan 9, 2019
MemberAuthor
BridgeAR
approved these changes
Jan 10, 2019
tniessen added a commit
to tniessen/node
that referenced
this pull request
Jan 11, 2019
PR-URL: nodejs#25400 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
tniessen
commented
Jan 11, 2019
MemberAuthor
Landed in 7710235, thanks for reviewing! |
addaleax pushed a commit
that referenced
this pull request
Jan 14, 2019
PR-URL: #25400 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
PR-URL: nodejs#25400 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Apr 28, 2019
PR-URL: #25400 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BethGriggs pushed a commit
that referenced
this pull request
May 10, 2019
PR-URL: #25400 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit
that referenced
this pull request
May 16, 2019
PR-URL: #25400 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These error conditions are currently not being tested:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes