Skip to content

os: improve networkInterfaces() performance - #25410

Closed
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:os-networkinterfaces-refactor
Closed

os: improve networkInterfaces() performance#25410
mscdex wants to merge 1 commit into
nodejs:masterfrom
mscdex:os-networkinterfaces-refactor

Conversation

@mscdex

@mscdexmscdex commented Jan 9, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

With included benchmark:

 confidence improvement accuracy (*) (**) (***)
os/networkInterfaces.js n=10000 *** 3.86 % ±0.26% ±0.34% ±0.44%

and also makes the C++ implementation mirror the C++ cpu enumeration code for whatever that's worth.

CI: https://ci.nodejs.org/job/node-test-pull-request/20031/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mscdexmscdex added os Issues and PRs related to the os subsystem. performance Issues and PRs related to the performance of Node.js. labels Jan 9, 2019
@nodejs-github-bot

nodejs-github-bot commented Jan 9, 2019

Copy link
Copy Markdown
Collaborator

@mscdex build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2197/pipeline

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 9, 2019
jdalton
jdalton reviewed Jan 9, 2019
View reviewed changes
Comment threadlib/os.js Outdated

@jdaltonjdaltonJan 9, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the perf benefit for networkInterfaces()?

@mscdexmscdexJan 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

@jdaltonjdaltonJan 9, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance it looks like a lot of unrolled code with an extra object being created. Could you please step me through the optimization being done in networkInterfaces(). If you drop the rework to networkInterfaces() do you still see perf wins?

@mscdexmscdexJan 9, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's more or less moving the object creation from C++ to JS land, just like we do for CPU enumeration.

BridgeAR
BridgeAR reviewed Jan 9, 2019
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally wonder if it would not be faster to just move everything to C++ instead.

The changes LGTM besides the result object. It should be kept as regular object.

Comment threadlib/os.js Outdated
@mscdex
mscdexforce-pushed the os-networkinterfaces-refactor branch from d7b7cde to b505976CompareJanuary 9, 2019 19:33
@BridgeAR

BridgeAR commented Jan 10, 2019

Copy link
Copy Markdown
Member

Resumed CI https://ci.nodejs.org/job/node-test-commit/24935/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 10, 2019
@danbev

danbev commented Jan 14, 2019

Copy link
Copy Markdown
Contributor

Landed in 5021b25.

@danbevdanbev closed this Jan 14, 2019
danbev pushed a commit that referenced this pull request Jan 14, 2019
@mscdex@danbev
os: improve networkInterfaces() performance
5021b25
PR-URL: #25410
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@mscdex
mscdex deleted the os-networkinterfaces-refactor branch January 14, 2019 07:14
addaleax pushed a commit that referenced this pull request Jan 14, 2019
@mscdex@addaleax
os: improve networkInterfaces() performance
840ec23
PR-URL: #25410
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeARBridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@mscdex@BridgeAR
os: improve networkInterfaces() performance
173f9d0
PR-URL: nodejs#25410
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@jdaltonjdaltonjdalton left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.osIssues and PRs related to the os subsystem.performanceIssues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mscdex@nodejs-github-bot@BridgeAR@danbev@jdalton@jasnell