Uh oh!
There was an error while loading. Please reload this page.
test: remove unnecessary skipIfWorker() - #25427
Closed
Trott wants to merge 1 commit into
Closed
Conversation
test-inspector-port-cluster passes in workers. Remove skipIfWorker() from the test.
MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/20041/ (:heavy_check_mark:) |
eugeneo
approved these changes
Jan 10, 2019
BridgeAR
approved these changes
Jan 10, 2019
benjamingr
approved these changes
Jan 10, 2019
cjihrig
approved these changes
Jan 10, 2019
lpinca
approved these changes
Jan 10, 2019
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jan 12, 2019
test-inspector-port-cluster passes in workers. Remove skipIfWorker() from the test. PR-URL: nodejs#25427 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
commented
Jan 12, 2019
MemberAuthor
Landed in 91ef9c4 |
addaleax pushed a commit
that referenced
this pull request
Jan 14, 2019
test-inspector-port-cluster passes in workers. Remove skipIfWorker() from the test. PR-URL: #25427 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 16, 2019
test-inspector-port-cluster passes in workers. Remove skipIfWorker() from the test. PR-URL: nodejs#25427 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Apr 28, 2019
test-inspector-port-cluster passes in workers. Remove skipIfWorker() from the test. PR-URL: #25427 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
May 10, 2019
test-inspector-port-cluster passes in workers. Remove skipIfWorker() from the test. PR-URL: #25427 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 16, 2019
test-inspector-port-cluster passes in workers. Remove skipIfWorker() from the test. PR-URL: #25427 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-inspector-port-cluster passes in workers. Remove skipIfWorker()
from the test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes