Uh oh!
There was an error while loading. Please reload this page.
src: cleanup cli options on internalBinding('config') - #25463
Closed
joyeecheung wants to merge 2 commits into
Closed
src: cleanup cli options on internalBinding('config')#25463joyeecheung wants to merge 2 commits into
internalBinding('config')#25463joyeecheung wants to merge 2 commits into
Conversation
Instead of using `internalBinding('config')` which should be used
to carry information about build-time options, directly pass the
run-time cli options into bootstrap/loaders.js lexically via
function arguments.Remove the following properties:
- `preserveSymlinks`
- `preserveSymlinksMain`
- `experimentalModules`
- `userLoader`
- `experimentalVMModules`
- `experimentalREPLAwait`
- `exposeInternals`
We used to use them to pass cli option values from C++ into
JS, but now the values are obtained in JS land using
`require('internal/options').getOptionValue` instead so they
are unused.
Also removes `test/parallel/test-internal-modules-expose.js`
which tests `--expose-internals`.
We already have hundreds of tests depending on `--expose-internals`,
they are more than enough to test the functionality of the flag.nodejs-github-bot
commented
Jan 12, 2019
Collaborator
@joyeecheung sadly an error occured when I tried to trigger a build :( |
joyeecheung
commented
Jan 12, 2019
MemberAuthor
addaleax
approved these changes
Jan 12, 2019
addaleax
commented
Jan 13, 2019
Member
refack
approved these changes
Jan 13, 2019
refack
commented
Jan 13, 2019
Contributor
danbev
commented
Jan 15, 2019
Contributor
Re-run of failing node-test-commit-arm |
joyeecheung
commented
Jan 16, 2019
MemberAuthor
This was referenced Jan 16, 2019
joyeecheung
commented
Jan 16, 2019
MemberAuthor
joyeecheung
commented
Jan 16, 2019
MemberAuthor
joyeecheung
commented
Jan 16, 2019
MemberAuthor
Landed in 6b2af91...2190d47 |
joyeecheung added a commit
that referenced
this pull request
Jan 16, 2019
Instead of using `internalBinding('config')` which should be used
to carry information about build-time options, directly pass the
run-time cli options into bootstrap/loaders.js lexically via
function arguments.
PR-URL: #25463
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>joyeecheung added a commit
that referenced
this pull request
Jan 16, 2019
Remove the following properties:
- `preserveSymlinks`
- `preserveSymlinksMain`
- `experimentalModules`
- `userLoader`
- `experimentalVMModules`
- `experimentalREPLAwait`
- `exposeInternals`
We used to use them to pass cli option values from C++ into
JS, but now the values are obtained in JS land using
`require('internal/options').getOptionValue` instead so they
are unused.
Also removes `test/parallel/test-internal-modules-expose.js`
which tests `--expose-internals`.
We already have hundreds of tests depending on `--expose-internals`,
they are more than enough to test the functionality of the flag.
PR-URL: #25463
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>addaleax
commented
Jan 23, 2019
Member
@joyeecheung This would need to be backported to v11.x-staging manually |
antsmartian pushed a commit
to antsmartian/node
that referenced
this pull request
Feb 7, 2019
Instead of using `internalBinding('config')` which should be used
to carry information about build-time options, directly pass the
run-time cli options into bootstrap/loaders.js lexically via
function arguments.
PR-URL: nodejs#25463
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>antsmartian pushed a commit
to antsmartian/node
that referenced
this pull request
Feb 7, 2019
Remove the following properties:
- `preserveSymlinks`
- `preserveSymlinksMain`
- `experimentalModules`
- `userLoader`
- `experimentalVMModules`
- `experimentalREPLAwait`
- `exposeInternals`
We used to use them to pass cli option values from C++ into
JS, but now the values are obtained in JS land using
`require('internal/options').getOptionValue` instead so they
are unused.
Also removes `test/parallel/test-internal-modules-expose.js`
which tests `--expose-internals`.
We already have hundreds of tests depending on `--expose-internals`,
they are more than enough to test the functionality of the flag.
PR-URL: nodejs#25463
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>2 tasks
targos pushed a commit
that referenced
this pull request
Feb 10, 2019
Instead of using `internalBinding('config')` which should be used
to carry information about build-time options, directly pass the
run-time cli options into bootstrap/loaders.js lexically via
function arguments.
PR-URL: #25463
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Backport-PR-URL: #26027targos pushed a commit
that referenced
this pull request
Feb 10, 2019
Remove the following properties:
- `preserveSymlinks`
- `preserveSymlinksMain`
- `experimentalModules`
- `userLoader`
- `experimentalVMModules`
- `experimentalREPLAwait`
- `exposeInternals`
We used to use them to pass cli option values from C++ into
JS, but now the values are obtained in JS land using
`require('internal/options').getOptionValue` instead so they
are unused.
Also removes `test/parallel/test-internal-modules-expose.js`
which tests `--expose-internals`.
We already have hundreds of tests depending on `--expose-internals`,
they are more than enough to test the functionality of the flag.
PR-URL: #25463
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Backport-PR-URL: #26027 Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src: pass cli options to bootstrap/loaders.js lexically
Instead of using
internalBinding('config')which should be usedto carry information about build-time options, directly pass the
run-time cli options into bootstrap/loaders.js lexically via
function arguments.
src: remove unused
internalBinding('config')propertiesRemove the following properties:
preserveSymlinkspreserveSymlinksMainexperimentalModulesuserLoaderexperimentalVMModulesexperimentalREPLAwaitexposeInternalsWe used to use them to pass cli option values from C++ into
JS, but now the values are obtained in JS land using
require('internal/options').getOptionValueinstead so theyare unused.
Also removes
test/parallel/test-internal-modules-expose.jswhich tests
--expose-internals.We already have hundreds of tests depending on
--expose-internals,they are more than enough to test the functionality of the flag.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes