Uh oh!
There was an error while loading. Please reload this page.
test: add check for wrk to test-keep-alive - #25516
Closed
Trott wants to merge 1 commit into
Closed
Conversation
test/pummel/test-keep-alive.js requires `wrk` to be installed. Check if it is, and skip the test if it isn't. This is yet another step in preparation for running pummel tests in CI daily.
nodejs-github-bot
commented
Jan 15, 2019
Collaborator
@Trott sadly an error occured when I tried to trigger a build :( |
Trott
commented
Jan 15, 2019
MemberAuthor
Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2252/ Running the test in CI to confirm it gets skiipped now (scheduled): https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/3901/ |
Trott
commented
Jan 15, 2019
MemberAuthor
(Since pummel tests are not run in CI yet, lite CI is sufficient.) |
cjihrig
approved these changes
Jan 15, 2019
Trott
commented
Jan 15, 2019
MemberAuthor
Linter failure was some leftover git files on the CI machine from some previous run. Cleared manually. Re-running. |
richardlau
approved these changes
Jan 15, 2019
lpinca
approved these changes
Jan 15, 2019
BridgeAR
approved these changes
Jan 16, 2019
jasnell
approved these changes
Jan 17, 2019
Trott
commented
Jan 18, 2019
MemberAuthor
Landed in 5fdd554 |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Jan 18, 2019
test/pummel/test-keep-alive.js requires `wrk` to be installed. Check if it is, and skip the test if it isn't. This is yet another step in preparation for running pummel tests in CI daily. PR-URL: nodejs#25516 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Jan 23, 2019
test/pummel/test-keep-alive.js requires `wrk` to be installed. Check if it is, and skip the test if it isn't. This is yet another step in preparation for running pummel tests in CI daily. PR-URL: #25516 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Apr 29, 2019
test/pummel/test-keep-alive.js requires `wrk` to be installed. Check if it is, and skip the test if it isn't. This is yet another step in preparation for running pummel tests in CI daily. PR-URL: #25516 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
May 10, 2019
test/pummel/test-keep-alive.js requires `wrk` to be installed. Check if it is, and skip the test if it isn't. This is yet another step in preparation for running pummel tests in CI daily. PR-URL: #25516 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 16, 2019
test/pummel/test-keep-alive.js requires `wrk` to be installed. Check if it is, and skip the test if it isn't. This is yet another step in preparation for running pummel tests in CI daily. PR-URL: #25516 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/pummel/test-keep-alive.js requires
wrkto be installed. Check ifit is, and skip the test if it isn't.
This is yet another step in preparation for running pummel tests in CI
daily.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes