Uh oh!
There was an error while loading. Please reload this page.
doc: clarify what dns.setResolvers() affects - #25570
Conversation
5a91f8d to
ccec12aCompareThere was a problem hiding this comment.
Nit: unneeded empty line?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ccec12a to
905a392Comparesam-github
commented
Jan 23, 2019
I haven't changed this text, and don't want to get into it here. I'll add it to my todo list. Can you reference the PR that did this? It'll need YAML change markers. If you don't know, I'll track it down some time. The structure of the docs are confusing. The Resolver class refers to the global docs, but it really be the other way around, the Resolver methods should be documented, and the globals should state that there is a global Resolver. An astute reader could guess that its implemented like this, but it isn't clearly stated. |
addaleax
commented
Jan 23, 2019
It does not affect dns.lookup().
905a392 to
d003bcdComparesam-github
commented
Jan 24, 2019
sam-github
commented
Jan 25, 2019
Landed in 0ce615c |
It does not affect dns.lookup(). PR-URL: #25570 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
It does not affect dns.lookup(). PR-URL: #25570 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
It does not affect dns.lookup(). PR-URL: #25570 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
It does not affect dns.lookup(). PR-URL: #25570 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
It does not affect dns.lookup().
cf. #25560
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes