Skip to content

doc: correct my wrong note about buf.fill() - #25585

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-del-buf-fill-255
Closed

doc: correct my wrong note about buf.fill()#25585
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-del-buf-fill-255

Conversation

@vsemozhetbyt

@vsemozhetbytvsemozhetbyt commented Jan 19, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Sorry, I've misinterpreted this operation:

node/src/node_buffer.cc

Line 566 in c1ac578

int value = val & 255; 

> Buffer.alloc(5).fill(255)
<Buffer ff ff ff ff ff>
> Buffer.alloc(5).fill(256)
<Buffer 00 00 00 00 00>
> Buffer.alloc(5).fill(257)
<Buffer 01 01 01 01 01>
> Buffer.alloc(5).fill(258)
<Buffer 02 02 02 02 02>

@nodejs-github-bot

nodejs-github-bot commented Jan 19, 2019

Copy link
Copy Markdown
Collaborator

@vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2302/pipeline

@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Jan 19, 2019
@vsemozhetbyt

vsemozhetbyt commented Jan 19, 2019

Copy link
Copy Markdown
ContributorAuthor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbytvsemozhetbyt mentioned this pull request Jan 19, 2019
Closed
3 tasks
@vsemozhetbytvsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 20, 2019
vsemozhetbyt added a commit that referenced this pull request Jan 20, 2019
@vsemozhetbyt
doc: correct my wrong note about buf.fill()
17c6b1d
PR-URL: #25585
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@vsemozhetbyt

vsemozhetbyt commented Jan 20, 2019

Copy link
Copy Markdown
ContributorAuthor

Landed in 17c6b1d
Thank you for the reviews.

@vsemozhetbyt
vsemozhetbyt deleted the doc-del-buf-fill-255 branch January 20, 2019 15:06
addaleax pushed a commit that referenced this pull request Jan 23, 2019
@vsemozhetbyt@addaleax
doc: correct my wrong note about buf.fill()
0c046e8
PR-URL: #25585
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@vsemozhetbyt@BethGriggs
doc: correct my wrong note about buf.fill()
8d309dc
PR-URL: #25585
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@vsemozhetbyt@BethGriggs
doc: correct my wrong note about buf.fill()
eb3b516
PR-URL: #25585
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@vsemozhetbyt@MylesBorins
doc: correct my wrong note about buf.fill()
13205d5
PR-URL: #25585
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeRChALkeRChALkeR approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.bufferIssues and PRs related to the buffer subsystem.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vsemozhetbyt@nodejs-github-bot@ChALkeR@addaleax@lpinca