Uh oh!
There was an error while loading. Please reload this page.
build: remove erroneous duplicate declaration from node_inspector.gypi - #25586
Closed
refack wants to merge 0 commit into
Closed
build: remove erroneous duplicate declaration from node_inspector.gypi#25586refack wants to merge 0 commit into
refack wants to merge 0 commit into
Conversation
addaleax
approved these changes
Jan 19, 2019
cjihrig
approved these changes
Jan 19, 2019
refackforce-pushed
the
inspector_gypi_oops
branch
from
January 22, 2019 17:09
85cd14b to
5b6a4e6Comparerefack
commented
Jan 22, 2019
ContributorAuthor
refack added a commit
that referenced
this pull request
Jan 22, 2019
PR-URL: #25586 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refackforce-pushed
the
inspector_gypi_oops
branch
from
January 22, 2019 21:21
5b6a4e6 to
5d80f9eComparerefack
commented
Jan 22, 2019
ContributorAuthor
landed in 5d80f9e |
addaleax pushed a commit
that referenced
this pull request
Jan 23, 2019
PR-URL: #25586 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
Apr 29, 2019
PR-URL: #25586 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
BethGriggs pushed a commit
that referenced
this pull request
May 10, 2019
PR-URL: #25586 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
May 16, 2019
PR-URL: #25586 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oops.
Duplicate/overriding declarations are on:
https://github.com/nodejs/node/blob/85cd14bd33443e81648a8f8b5eb911d909714fd3/src/inspector/node_inspector.gypi#L104
and
https://github.com/nodejs/node/blob/85cd14bd33443e81648a8f8b5eb911d909714fd3/src/inspector/node_inspector.gypi#L138
/CC @nodejs/build-files @nodejs/v8-inspector
CI: https://ci.nodejs.org/job/node-test-pull-request/20207/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes