Uh oh!
There was an error while loading. Please reload this page.
src: simplify inspector initialization in node::Start() - #25612
Closed
joyeecheung wants to merge 1 commit into
Closed
src: simplify inspector initialization in node::Start()#25612joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
Remove the `StartInspector` and `InspectorStarted` abstraction out of `v8_platform`, and error out early and directly in the option parser if Node is configured with NODE_USE_V8_PLATFORM and inspector enabled but the user still tries to use inspector options.
joyeecheung
commented
Jan 21, 2019
MemberAuthor
addaleax
approved these changes
Jan 21, 2019
bnoordhuis
approved these changes
Jan 21, 2019
cjihrig
approved these changes
Jan 21, 2019
joyeecheung
commented
Jan 24, 2019
MemberAuthor
danbev
commented
Jan 25, 2019
Contributor
Re-run of failing node-test-commit-linux |
addaleax
commented
Jan 27, 2019
Member
Landed in e3e4048 |
addaleax pushed a commit
that referenced
this pull request
Jan 27, 2019
Remove the `StartInspector` and `InspectorStarted` abstraction out of `v8_platform`, and error out early and directly in the option parser if Node is configured with NODE_USE_V8_PLATFORM and inspector enabled but the user still tries to use inspector options. PR-URL: #25612 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Jan 28, 2019
Remove the `StartInspector` and `InspectorStarted` abstraction out of `v8_platform`, and error out early and directly in the option parser if Node is configured with NODE_USE_V8_PLATFORM and inspector enabled but the user still tries to use inspector options. PR-URL: #25612 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
StartInspectorandInspectorStartedabstractionout of
v8_platform, and error out early and directly in theoption parser if Node is configured with NODE_USE_V8_PLATFORM and
inspector enabled but the user still tries to use inspector options.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes