Skip to content

doc: running coverage for individual suites - #25622

Closed
bcoe wants to merge 1 commit into
nodejs:masterfrom
bcoe:run-isolated-suites
Closed

doc: running coverage for individual suites#25622
bcoe wants to merge 1 commit into
nodejs:masterfrom
bcoe:run-isolated-suites

Conversation

@bcoe

@bcoebcoe commented Jan 21, 2019

Copy link
Copy Markdown
Contributor

follow up from d1dee49, adding @thefourtheye's documentation request.

Checklist

@bcoebcoe added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 21, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jan 21, 2019
Comment threadBUILDING.md Outdated
Comment threadBUILDING.md Outdated

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcoe

bcoe commented Jan 22, 2019

Copy link
Copy Markdown
ContributorAuthor

@vsemozhetbyt added the additional ticks, also noticed the paragraph below was a bit redundant and reworded.

If folks are alright with this pass at the documentation, I'm advocating this doc change is probably okay to fast track.

@bcoe
bcoeforce-pushed the run-isolated-suites branch from a577e27 to f598618CompareJanuary 22, 2019 20:15
@bcoe

bcoe commented Jan 22, 2019

Copy link
Copy Markdown
ContributorAuthor

@bcoe

bcoe commented Jan 23, 2019

Copy link
Copy Markdown
ContributorAuthor

Landed in 885b3bc

@bcoebcoe closed this Jan 23, 2019
@bcoe
bcoe deleted the run-isolated-suites branch January 23, 2019 01:23
bcoe added a commit to bcoe/node-1 that referenced this pull request Jan 23, 2019
PR-URL: nodejs#25622
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@bcoe

bcoe commented Jan 23, 2019

Copy link
Copy Markdown
ContributorAuthor

Landed in e3f917e

addaleax pushed a commit that referenced this pull request Jan 23, 2019
PR-URL: #25622
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@bcoe@nodejs-github-bot@thefourtheye@mhdawson@vsemozhetbyt