Uh oh!
There was an error while loading. Please reload this page.
report: represent numbers as numbers - #25651
Closed
addaleax wants to merge 2 commits into
Closed
Conversation
- Support non-string entry types - Prefer single-character writes over string writes - Rename the state constants and adjust style to match more common Node.js style
Do not stringify numbers and boolean values when writing JSON.
cjihrig
approved these changes
Jan 23, 2019
mmarchini
approved these changes
Jan 23, 2019
gireeshpunathil
approved these changes
Jan 24, 2019
BethGriggs
approved these changes
Jan 24, 2019
addaleax
commented
Jan 24, 2019
MemberAuthor
addaleax
commented
Jan 24, 2019
MemberAuthor
richardlau
approved these changes
Jan 24, 2019
addaleax
commented
Jan 25, 2019
MemberAuthor
Resume CI again: https://ci.nodejs.org/job/node-test-pull-request/20332/ |
addaleax
commented
Jan 27, 2019
MemberAuthor
addaleax
commented
Jan 27, 2019
MemberAuthor
Sigh… let’s try a fresh full CI: https://ci.nodejs.org/job/node-test-pull-request/20353/ |
addaleax
commented
Jan 27, 2019
MemberAuthor
addaleax added a commit
that referenced
this pull request
Jan 27, 2019
- Support non-string entry types - Prefer single-character writes over string writes - Rename the state constants and adjust style to match more common Node.js style PR-URL: #25651 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax added a commit
that referenced
this pull request
Jan 27, 2019
Do not stringify numbers and boolean values when writing JSON. PR-URL: #25651 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax added a commit
that referenced
this pull request
Jan 28, 2019
- Support non-string entry types - Prefer single-character writes over string writes - Rename the state constants and adjust style to match more common Node.js style PR-URL: #25651 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax added a commit
that referenced
this pull request
Jan 28, 2019
Do not stringify numbers and boolean values when writing JSON. PR-URL: #25651 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
report: refactor JSON writer
report: represent numbers as numbers
Do not stringify numbers and boolean values when writing JSON.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes