Uh oh!
There was an error while loading. Please reload this page.
streams: refactor LazyTransform to internal/ - #2566
Closed
brendanashworth wants to merge 2 commits into
Closed
Conversation
This commit refactors LazyTransform from the crypto implementation (lib/crypto.js) into an internal module (not publicy accessible) in internal/streams/LazyTransform.js. This promotes a more modular core design and removes code bloat in crypto, as LazyTransform didn't specifically have anything to do with cryptography, but rather a fast way to support two APIs on a stream.
brendanashworth
commented
Sep 11, 2015
ContributorAuthor
r=@nodejs/crypto ? |
indutny
commented
Sep 11, 2015
Member
I think it would be the first module to use camel case file name. Should it really have it? Otherwise, LGTM |
brendanashworth
commented
Sep 12, 2015
ContributorAuthor
I don't have a preference, I can change it to |
indutny
commented
Sep 12, 2015
Member
I think |
brendanashworth
commented
Sep 12, 2015
ContributorAuthor
Updated with a rename. Here is a CI: https://ci.nodejs.org/view/iojs/job/node-test-pull-request/284/. |
indutny
commented
Sep 12, 2015
Member
LGTM |
Fishrock123
commented
Sep 14, 2015
Contributor
Hmm, not sure if CI is happy. New run: https://ci.nodejs.org/job/node-test-pull-request/297/ |
Fishrock123
commented
Sep 14, 2015
Contributor
@brendanashworth CI seems good. |
brendanashworth added a commit
that referenced
this pull request
Sep 15, 2015
This commit refactors LazyTransform from the crypto implementation (lib/crypto.js) into an internal module (not publicy accessible) in internal/streams/lazy_transform.js. This promotes a more modular core design and removes code bloat in crypto, as LazyTransform didn't specifically have anything to do with cryptography, but rather a fast way to support two APIs on a stream. PR-URL: #2566 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
brendanashworth
commented
Sep 15, 2015
ContributorAuthor
Thank you, landed in c70c778. |
brendanashworth added a commit
that referenced
this pull request
Sep 15, 2015
This commit refactors LazyTransform from the crypto implementation (lib/crypto.js) into an internal module (not publicy accessible) in internal/streams/lazy_transform.js. This promotes a more modular core design and removes code bloat in crypto, as LazyTransform didn't specifically have anything to do with cryptography, but rather a fast way to support two APIs on a stream. PR-URL: #2566 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
brendanashworth added a commit
that referenced
this pull request
Sep 15, 2015
This commit refactors LazyTransform from the crypto implementation (lib/crypto.js) into an internal module (not publicy accessible) in internal/streams/lazy_transform.js. This promotes a more modular core design and removes code bloat in crypto, as LazyTransform didn't specifically have anything to do with cryptography, but rather a fast way to support two APIs on a stream. PR-URL: #2566 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors
LazyTransformfrom the crypto implementation(
lib/crypto.js) into an internal module (not publicy accessible) ininternal/streams/LazyTransform.js. This promotes a more modular coredesign and removes code bloat in crypto, as
LazyTransformdidn'tspecifically have anything to do with cryptography, but rather a fast
way to support two APIs on a stream.