Skip to content

test: refactor test-*-ci-reneg-attack.js - #25660

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:update-tls-reneg
Closed

test: refactor test-*-ci-reneg-attack.js#25660
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:update-tls-reneg

Conversation

@Trott

Copy link
Copy Markdown
Member

Refactor test-tls-ci-reneg-attack:

  • Use port 0 (OS-assigned available port) rather than common.PORT
  • Remove unnecessary boolean that causes race condition failure on some
    operating systems

Refactor that test and test-https-ci-reneg-attack:

  • Check all stderr, not just the chunk coming in now, in case it breaks
    up chunks in the middle of where the regexps are supposed to match.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Refactor test-tls-ci-reneg-attack:
* Use port 0 (OS-assigned available port) rather than common.PORT
* Remove unnecessary boolean that causes race condition failure on some
operating systems
Refactor that test and test-https-ci-reneg-attack:
* Check all stderr, not just the chunk coming in now, in case it breaks
up chunks in the middle of where the regexps are supposed to match.
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jan 23, 2019
@TrottTrott mentioned this pull request Jan 24, 2019
2 tasks
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 25, 2019
@Trott

Copy link
Copy Markdown
MemberAuthor

Pummel tests are not run in CI, so lite CI should be sufficient. Might run a full pummel test suite if we get the pummel tests fixed (in other PRs)...

@Trott

Copy link
Copy Markdown
MemberAuthor

Closing in favor of #25700 and #25720. (Those both need reviews, so feel free to head over there to get them landed and get the pummel test suite green again.)

@TrottTrott closed this Jan 26, 2019
@Trott
Trott deleted the update-tls-reneg branch January 13, 2022 22:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Trott@nodejs-github-bot@apapirovski