Skip to content

test: fix sequential/test-performance delay - #25695

Closed
apapirovski wants to merge 1 commit into
nodejs:masterfrom
apapirovski:fix-test-performance
Closed

test: fix sequential/test-performance delay#25695
apapirovski wants to merge 1 commit into
nodejs:masterfrom
apapirovski:fix-test-performance

Conversation

@apapirovski

@apapirovskiapapirovski commented Jan 25, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

This should resolve the flakiness on this test on slower systems where the inited time we store in JS can be much later than the nodeTiming one.

Fixes: #23291

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Jan 25, 2019

Copy link
Copy Markdown
Collaborator

@apapirovski build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2382/pipeline

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jan 25, 2019
@Trott

Trott commented Jan 25, 2019•
edited
Loading

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20317/ ✅

TimothyGu
TimothyGu approved these changes Jan 25, 2019
View reviewed changes

@TimothyGuTimothyGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some… quite slow machines. But LGTM, if they are confirmed to fix the flakiness to a satisfactory level.

@TrottTrott mentioned this pull request Jan 25, 2019
Closed
@Trott

Trott commented Jan 25, 2019

Copy link
Copy Markdown
Member

These are some… quite slow machines.

Indeed a Raspberry Pi can have as little as 256 Mb of RAM and a 700 MHz processor. Not sure if that's the spec for these machines, but it certainly gives you the idea.

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 25, 2019
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 25, 2019
@Trott

Trott commented Jan 25, 2019

Copy link
Copy Markdown
Member

Please 👍 here to approve fast-tracking to unbreak CI.

@Trott

Trott commented Jan 26, 2019

Copy link
Copy Markdown
Member

Landed in d1d357d

@TrottTrott closed this Jan 26, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 26, 2019
@apapirovski@Trott
test: fix sequential/test-performance delay
d1d357d
PR-URL: nodejs#25695Fixes: nodejs#23291
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@gireeshpunathilgireeshpunathil mentioned this pull request Jan 26, 2019
Closed
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@apapirovski@addaleax
test: fix sequential/test-performance delay
f33d705
PR-URL: #25695Fixes: #23291
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@targostargos mentioned this pull request Jan 29, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
@apapirovski@BethGriggs
test: fix sequential/test-performance delay
d744de4
PR-URL: #25695Fixes: #23291
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs pushed a commit that referenced this pull request May 10, 2019
@apapirovski@BethGriggs
test: fix sequential/test-performance delay
3f0bc59
PR-URL: #25695Fixes: #23291
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@apapirovski@MylesBorins
test: fix sequential/test-performance delay
301f5fb
PR-URL: #25695Fixes: #23291
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@cjihrigcjihrigcjihrig approved these changes
@jasnelljasnellAwaiting requested review from jasnell
+2 more reviewers
@Fishrock123Fishrock123Fishrock123 approved these changes
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky sequential/test-performance

6 participants

@apapirovski@nodejs-github-bot@Trott@Fishrock123@TimothyGu@cjihrig