Skip to content

doc: add metadata to report docs - #25708

Closed
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:report-introduced-in
Closed

doc: add metadata to report docs#25708
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:report-introduced-in

Conversation

@richardlau

@richardlaurichardlau commented Jan 25, 2019

Copy link
Copy Markdown
Member

Fixes: #25682

I based the metadata based on the other files in doc/ (we don't seem to have much (any?) documentation on what metadata should be included).

cc @nodejs/documentation

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Jan 25, 2019

Copy link
Copy Markdown
Collaborator

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2388/pipeline

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. report Issues and PRs related to process.report. labels Jan 25, 2019
@vsemozhetbyt

vsemozhetbyt commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 25, 2019
@addaleax

addaleax commented Jan 25, 2019

Copy link
Copy Markdown
Member

Landed in f40778e

addaleax pushed a commit that referenced this pull request Jan 25, 2019
@richardlau@addaleax
doc: add metadata to report docs
f40778e
Fixes: #25682
PR-URL: #25708
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@richardlau@addaleax
doc: add metadata to report docs
e475119
Fixes: #25682
PR-URL: #25708
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targostargos mentioned this pull request Jan 29, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.reportIssues and PRs related to process.report.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test-doc failed to add alternative version links

5 participants

@richardlau@nodejs-github-bot@vsemozhetbyt@addaleax@cjihrig