Skip to content

doc: fix metadata for v11.8.0 doc changes - #25709

Closed
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:replacereplaceme
Closed

doc: fix metadata for v11.8.0 doc changes#25709
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:replacereplaceme

Conversation

@richardlau

@richardlaurichardlau commented Jan 25, 2019

Copy link
Copy Markdown
Member

Refs: 641de82

cc @MylesBorins

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Jan 25, 2019

Copy link
Copy Markdown
Collaborator

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2389/pipeline

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 25, 2019
@richardlaurichardlau mentioned this pull request Jan 25, 2019
Closed
@richardlau

richardlau commented Jan 25, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

See #25705 (comment). I'll leave it to @MylesBorins to decide if this PR should be folded into #25705.

@addaleax

addaleax commented Jan 25, 2019

Copy link
Copy Markdown
Member

Please 👍 this comment to approve fast-tracking

@addaleaxaddaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 25, 2019
@vsemozhetbytvsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 25, 2019
MylesBorins
MylesBorins approved these changes Jan 25, 2019
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott

Trott commented Jan 26, 2019

Copy link
Copy Markdown
Member

Landed in bbb2134

@TrottTrott closed this Jan 26, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Jan 26, 2019
@richardlau@Trott
doc: fix metadata for v11.8.0 doc changes
bbb2134
Refs: nodejs@641de82
PR-URL: nodejs#25709
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@richardlau@addaleax
doc: fix metadata for v11.8.0 doc changes
1aa7f4d
Refs: 641de82
PR-URL: #25709
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targostargos mentioned this pull request Jan 29, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+2 more reviewers
@MylesBorinsMylesBorinsMylesBorins approved these changes
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@richardlau@nodejs-github-bot@addaleax@Trott@MylesBorins@lpinca@cjihrig@vsemozhetbyt