Uh oh!
There was an error while loading. Please reload this page.
src: remove unused env_ field from env.h - #25784
Closed
danbev wants to merge 1 commit into
Closed
Conversation
Currently the following compiler warnings is generated: In file included from ../src/env-inl.h:28: ../src/env.h:521:18: warning: private field 'env_' is not used [-Wunused-private-field] Environment* env_; ^ 1 warning generated. This commit removes this unused field.
richardlau
approved these changes
Jan 29, 2019
danbev
commented
Jan 29, 2019
ContributorAuthor
ContributorAuthor
Re-run of failing node-test-commit-linux (✔️) |
danbev
commented
Jan 29, 2019
ContributorAuthor
Please give a 👍 if you think this can be fast-tracked, or if you disagree please remove the |
addaleax
approved these changes
Jan 29, 2019
jasnell
approved these changes
Jan 29, 2019
joyeecheung
approved these changes
Jan 29, 2019
refack
approved these changes
Jan 30, 2019
danbev added a commit
that referenced
this pull request
Jan 30, 2019
Currently the following compiler warnings is generated: In file included from ../src/env-inl.h:28: ../src/env.h:521:18: warning: private field 'env_' is not used [-Wunused-private-field] Environment* env_; ^ 1 warning generated. This commit removes this unused field. PR-URL: #25784 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
danbev
commented
Jan 30, 2019
ContributorAuthor
targos pushed a commit
that referenced
this pull request
Jan 30, 2019
Currently the following compiler warnings is generated: In file included from ../src/env-inl.h:28: ../src/env.h:521:18: warning: private field 'env_' is not used [-Wunused-private-field] Environment* env_; ^ 1 warning generated. This commit removes this unused field. PR-URL: #25784 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the following compiler warnings is generated:
This commit removes this unused field.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes