Skip to content

test: do not fail SLOW tests if they are not slow - #25868

Closed
hashseed wants to merge 1 commit into
nodejs:masterfrom
hashseed:slowtests
Closed

test: do not fail SLOW tests if they are not slow#25868
hashseed wants to merge 1 commit into
nodejs:masterfrom
hashseed:slowtests

Conversation

@hashseed

@hashseedhashseed commented Feb 1, 2019

Copy link
Copy Markdown
Member

Make SLOW imply PASS.

Refs: #25867

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Feb 1, 2019

Copy link
Copy Markdown
Collaborator

@hashseed build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2481/pipeline

@nodejs-github-botnodejs-github-bot added test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Feb 1, 2019
@richardlaurichardlau mentioned this pull request Feb 1, 2019
Closed
2 tasks
@addaleax

addaleax commented Feb 2, 2019

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20546/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 2, 2019
@hashseed

hashseed commented Feb 4, 2019

Copy link
Copy Markdown
MemberAuthor

Looks like some Jenkins related issue?

@refack

refack commented Feb 4, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Looks like some Jenkins related issue?

Should be solved.
Resume: https://ci.nodejs.org/job/node-test-pull-request/20562/ ✔️

@refackrefack added landed and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 4, 2019
@refack

refack commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

Landed in dfe5f8f

@refackrefack closed this Feb 4, 2019
refack pushed a commit that referenced this pull request Feb 4, 2019
@hashseed@refack
test: do not fail SLOW tests if they are not slow
dfe5f8f
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
addaleax pushed a commit that referenced this pull request Feb 6, 2019
@hashseed@addaleax
test: do not fail SLOW tests if they are not slow
025a7c3
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@targostargos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@hashseed
hashseed deleted the slowtests branch February 15, 2019 12:49
@richardlaurichardlau mentioned this pull request Dec 2, 2019
Closed
BethGriggs pushed a commit that referenced this pull request Dec 4, 2019
@hashseed@BethGriggs
test: do not fail SLOW tests if they are not slow
fabbc76
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@BethGriggsBethGriggs mentioned this pull request Dec 4, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@hashseed@MylesBorins
test: do not fail SLOW tests if they are not slow
7e941eb
PR-URL: #25868
Refs: #25867
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
@BethGriggsBethGriggs mentioned this pull request Jan 7, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@richardlaurichardlaurichardlau approved these changes
+3 more reviewers
@refackrefackrefack approved these changes
@danbevdanbevdanbev approved these changes
@devsnekdevsnekdevsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@hashseed@nodejs-github-bot@addaleax@refack@danbev@richardlau@devsnek@BethGriggs