test: use tmp directory in chdir test

[thefourtheye]

This patch makes chdir test to use the tmp directory and moves the test
to parallel.

CI Run: https://jenkins-iojs.nodesource.com/job/node-test-pull-request/198/

[brendanashworth]

LGTM if CI is happy

[Fishrock123]

cc @nodejs/build this moves another test to /parallel/

[mscdex]

I think the filename of this test should be renamed to test-process-chdir.js since it's really testing process.chdir().

[thefourtheye]

@mscdex Good call. Thanks :-) Renamed the file.

[thefourtheye]

New CI Run: https://ci.nodejs.org/job/node-test-commit/581/

[Fishrock123]

I think this is effectively unsafe after using common.tmpDir?

Isn't it possible that your tmpDir is different then?

[thefourtheye]

@Fishrock123 refresh just removes the directory and creates it

exports.refreshTmpDir=function(){rimrafSync(exports.tmpDir);fs.mkdirSync(exports.tmpDir);};

The name is actually decided when we load the module itself,

if(process.env.TEST_THREAD_ID){// Distribute ports in parallel testsif(!process.env.NODE_COMMON_PORT)exports.PORT+=+process.env.TEST_THREAD_ID*100;exports.tmpDirName+='.'+process.env.TEST_THREAD_ID;}exports.tmpDir=path.join(exports.testDir,exports.tmpDirName);

Since we are just resolving the path before that, we are safe here.

[thefourtheye]

Test is passing in all the environments. @Fishrock123@mscdex LGTY?

[Trott]

LGTM if CI is happy

[thefourtheye]

Thanks for the review people. Landed in 9aa6a43