Uh oh!
There was an error while loading. Please reload this page.
test: mark test-trace-events-fs-sync as FLAKY - #25899
Conversation
refack
commented
Feb 2, 2019
I'd like to fast track this. Please 👍 if you concur. |
addaleax
commented
Feb 2, 2019
We also have the option of fast-tracking #25896 if you think there is urgency to resolve this? It's not a complex change, so I think this should be okay. |
addaleax
commented
Feb 2, 2019
If you do want to merge this, please add a reference to #25512 in the commit message. |
I'll verify that it solves the issue in a environment known to repro.
👍 with the magic of |
Trott
left a comment
There was a problem hiding this comment.
LGTM although obviously even better if the proposed solution works and we don't have to mark this as flaky at all.
refack
commented
Feb 2, 2019
Superseded by #25896 |
refack
commented
Feb 3, 2019
Reopening since #25896 seems to be taking longer. Please 👍 for FT. |
CI: https://ci.nodejs.org/job/node-test-pull-request/20556/ |
refack
commented
Feb 4, 2019
Superseded by #25896 |

Refs: #25512
Flake frequency ebbs and flows but it's still a pain.
Marking as FLAKY until we solve the underling issue.
/CC @nodejs/testing @gireeshpunathil@addaleax
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes