Skip to content

test: mark test-trace-events-fs-sync as FLAKY - #25899

Closed
refack wants to merge 1 commit into
nodejs:masterfrom
refack:flaky-test-trace-events-fs-sync
Closed

test: mark test-trace-events-fs-sync as FLAKY#25899
refack wants to merge 1 commit into
nodejs:masterfrom
refack:flaky-test-trace-events-fs-sync

Conversation

@refack

@refackrefack commented Feb 2, 2019

Copy link
Copy Markdown
Contributor

Refs: #25512

Flake frequency ebbs and flows but it's still a pain.
Marking as FLAKY until we solve the underling issue.

/CC @nodejs/testing @gireeshpunathil@addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 2, 2019
@refack
refack requested a review from TrottFebruary 2, 2019 17:55
@refackrefack added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 2, 2019
@refack

Copy link
Copy Markdown
ContributorAuthor

I'd like to fast track this. Please 👍 if you concur.

@addaleax

Copy link
Copy Markdown
Member

Marking as FLAKY until we solve the underling issue.

We also have the option of fast-tracking #25896 if you think there is urgency to resolve this? It's not a complex change, so I think this should be okay.

@addaleax

Copy link
Copy Markdown
Member

If you do want to merge this, please add a reference to #25512 in the commit message.

@refack

refack commented Feb 2, 2019

Copy link
Copy Markdown
ContributorAuthor

We also have the option of fast-tracking #25896 if you think there is urgency to resolve this? It's not a complex change, so I think this should be okay.

I'll verify that it solves the issue in a environment known to repro.

If you do want to merge this, please add a reference to #25512 in the commit message.

👍 with the magic of node-core-utils, it adds the Refs from the OP to the final commit message without getting all the
image
during review.

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although obviously even better if the proposed solution works and we don't have to mark this as flaky at all.

bcoe
bcoe approved these changes Feb 2, 2019
@refack

Copy link
Copy Markdown
ContributorAuthor

Superseded by #25896

@refackrefack closed this Feb 2, 2019
@refack
refack deleted the flaky-test-trace-events-fs-sync branch February 2, 2019 23:52
@refack
refack restored the flaky-test-trace-events-fs-sync branch February 3, 2019 16:10
@refack

Copy link
Copy Markdown
ContributorAuthor

Reopening since #25896 seems to be taking longer. Please 👍 for FT.

@refackrefack self-assigned this Feb 3, 2019
@refackrefack reopened this Feb 3, 2019
@refack

refack commented Feb 3, 2019

Copy link
Copy Markdown
ContributorAuthor

@refack

Copy link
Copy Markdown
ContributorAuthor

Superseded by #25896

@refackrefack closed this Feb 4, 2019
@refack
refack deleted the flaky-test-trace-events-fs-sync branch February 15, 2019 00:20
@refackrefack removed their assignment Mar 11, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.flaky-testIssues and PRs related to the tests with unstable failures on the CI.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@refack@nodejs-github-bot@addaleax@bcoe@Trott