Skip to content

src: use NULL check macros to check nullptr - #25916

Closed
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:src-nullptr
Closed

src: use NULL check macros to check nullptr#25916
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:src-nullptr

Conversation

@ZYSzys

@ZYSzysZYSzys commented Feb 4, 2019

Copy link
Copy Markdown
Member

Use CHECK_NULL and CHECK_NOT_NULL macros to check nullptr.

Refs: #20914

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 4, 2019
@addaleax

addaleax commented Feb 6, 2019

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/20622/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 6, 2019
@danbev

danbev commented Feb 7, 2019

Copy link
Copy Markdown
Contributor

Landed in 93e0c6a.

@danbevdanbev closed this Feb 7, 2019
danbev pushed a commit that referenced this pull request Feb 7, 2019
@ZYSzys@danbev
src: use NULL check macros to check nullptr
93e0c6a
PR-URL: #25916
Refs: #20914
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@ZYSzys
ZYSzys deleted the src-nullptr branch February 7, 2019 06:35
@targostargos mentioned this pull request Feb 10, 2019
Closed
targos pushed a commit that referenced this pull request Feb 10, 2019
@ZYSzys@targos
src: use NULL check macros to check nullptr
5de1034
PR-URL: #25916
Refs: #20914
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@targostargos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@shisamashisamashisama approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ZYSzys@addaleax@danbev@jasnell@richardlau@shisama@nodejs-github-bot