Uh oh!
There was an error while loading. Please reload this page.
tls: null not valid as a renegotiate callback - #25929
Closed
sam-github wants to merge 1 commit into
Closed
Conversation
Allow undefined as a callback, but do not allow null.
cjihrig
approved these changes
Feb 4, 2019
apapirovski
approved these changes
Feb 5, 2019
BridgeAR
approved these changes
Feb 5, 2019
lpinca
approved these changes
Feb 5, 2019
JungMinu
approved these changes
Feb 5, 2019
jasnell
approved these changes
Feb 5, 2019
sam-github
commented
Feb 5, 2019
ContributorAuthor
addaleax
commented
Feb 6, 2019
Member
Landed in 00d49ad |
addaleax pushed a commit
that referenced
this pull request
Feb 6, 2019
Allow undefined as a callback, but do not allow null. PR-URL: #25929 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
4 tasks
addaleax
commented
Feb 8, 2019
Member
@sam-github If I understood you correctly, this should be labelled dont-land-on-v11.x. |
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow undefined as a callback, but do not allow null.
Belatedly respond to #25876 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes