gyp, win: teach MSVS generator about MARMASM Items

[jkunkee]

The toolchain for ARM64 Windows includes support for assembly code, but with a very different syntax from MASM and NASM. This change teaches GYP how to emit the right XML tags in VCXPROJ files to support compiling assembly files with the new tool.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
  • not yet written
• commit message follows commit guidelines

[bnoordhuis]

Thanks, LGTM with a comment. CI: https://ci.nodejs.org/job/node-test-pull-request/20742/

[jkunkee]

@bnoordhuis, thanks for the look. Since that CI run failed, I've rebased the change. Please do let me know if there's anything else I need to do so this can land.

[refack]

This should come via the upstream change (refack/GYP3#23), since we have no way to CI this here.

[jkunkee]

Understood.

When I submitted this PR, my understanding was that there are three copies of GYP:

• https://github.com/nodejs/node/tree/master/tools/gyp
• https://github.com/nodejs/node-gyp/tree/master/gyp
• https://github.com/refack/gyp

refack/GYP had not yet become the centralized upstream of GYP for Node.js.

In turn, then, I made three PRs:

• gyp, win: teach MSVS generator about MARMASM Items #26020 (this PR)
• Add arm64 asm node-gyp#1679
• msvs: add ARM64 build file generation refack/GYP3#23

As I understand it, refack/GYP is becoming the new upstream. Since refack/GYP3#23 has already been merged, this PR can be closed as soon as the Node.js copy of GYP is updated to the new upstream.

[joaocgreis]

I had started a CI run that failed to compile with multiple errors of the form:

c:\workspace\node-compile-windows\**.vcxproj(30,3): error MSB4019: The imported project "C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\BuildCustomizations\marmasm.props" was not found. Confirm that the path in the <Import> declaration is correct, and that the file exists on disk.

I confirmed this was because VS2017 was not fully updated on that machine and that any updated installation of VS2017 should have that file, whether ARM components were selected or not. I endured VS2017 is updated and receiving automatic updated on all our machines, so we should not see this again.

[joaocgreis]

I'm ok with getting this from refack/GYP3#23, but anyway this LGTM.

[BridgeAR]

@refack can you please briefly elaborate what should be done here?

[BridgeAR]

Ping @refack

[refack]

Superseded by #26620

[joaocgreis]

With this PR, Node can be compiled in ARM64 Windows devices.

@refack since #26620 is still having issues with CI, do you mind if we land this one to have ARM64 support in master? This can simply be overwritten by #26620 when it lands.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22363/

[refack]

@refack since #26620 is still having issues with CI, do you mind if we land this one to have ARM64 support in master? This can simply be overwritten by #26620 when it lands.

In general I'm -1 on landing code that is not covered by our CI ¯\(ツ)/¯
At refack/GYP this code at least is tested for regressions.

[joaocgreis]

This is not code for a Tier 1 or 2 supported platform, but to enable compilation for an experimental platform. This was tested by CI for Tier 1 and 2 platforms, confirming it does not cause any regressions for those.

In any case, this has landed in refack/GYP in refack/GYP3#23, and is already part of #26620.

@refack since this is for an experimental platform is there a reason to block this from landing?

[refack]

since this is for an experimental platform is there a reason

Forgot it's designated experimental.

[joaocgreis]

Landed in 06c10cd