Skip to content

[WIP]tools: simply eslint tasks#26054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengjiawen wants to merge 2 commits into from
Closed

[WIP]tools: simply eslint tasks #26054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fecaca
tools: remove eslint in tools
gengjiawen Feb 12, 2019
be9743d
tools: remove eslint in tools
gengjiawen Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
4 changes: 1 addition & 3 deletions .eslintrc.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,9 +8,7 @@ NodePlugin.RULES_DIR = path.resolve(__dirname, 'tools', 'eslint-rules');

const ModuleFindPath = Module._findPath;
const hacks = [
'eslint-plugin-node-core',
'eslint-plugin-markdown',
'babel-eslint',
'eslint-plugin-node-core'

@gengjiawengengjiawenFeb 12, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other two on npm, so I installed them using internal npm.

@joyeecheungjoyeecheungFeb 17, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.npmjs.com/package/eslint-plugin-node-core has not been updated properly (though it's probably just a matter of running the update script again)

@gengjiawengengjiawenFeb 17, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that too. Perhaps just leave this plugin in this repo for now.

];
Module._findPath = (request, paths, isMain) => {
const r = ModuleFindPath(request, paths, isMain);
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -135,3 +135,5 @@ deps/v8/gypfiles/Release/
deps/v8/third_party/eu-strip/

.DS_Store
tools/node_modules/*
node_modules/*
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -705,6 +705,7 @@ out/doc/api/assets/%: doc/api_assets/% out/doc/api/assets

Comment thread
gengjiawen marked this conversation as resolved.
Outdated

run-npm-ci = $(PWD)/$(NPM) ci
run-npm-task = $(PWD)/$(NPM) run

LINK_DATA = out/doc/apilinks.json
gen-api = tools/doc/generate.js --node-version=$(FULLVERSION) \
Expand DownExpand Up@@ -1172,8 +1173,7 @@ lint-md: | tools/.mdlintstamp

LINT_JS_TARGETS = .eslintrc.js benchmark doc lib test tools

run-lint-js = tools/node_modules/eslint/bin/eslint.js --cache \
--report-unused-disable-directives --ext=.js,.mjs,.md $(LINT_JS_TARGETS)
run-lint-js = $(call available-node,$(run-npm-ci)) && $(call available-node,$(run-npm-task) lint)
run-lint-js-fix = $(run-lint-js) --fix

.PHONY: lint-js-fix
Expand Down
19 changes: 0 additions & 19 deletions deps/acorn/acorn-walk/LICENSE
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions deps/npm/node_modules/graceful-fs/LICENSE
View file
Open in desktop

This file was deleted.

133 changes: 0 additions & 133 deletions deps/npm/node_modules/graceful-fs/README.md
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions deps/npm/node_modules/graceful-fs/clone.js
View file
Open in desktop

This file was deleted.

Loading