Skip to content

doc: fix code lang in repl.md - #26075

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:fix-repl-doc
Closed

doc: fix code lang in repl.md#26075
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:fix-repl-doc

Conversation

@gengjiawen

@gengjiawengengjiawen commented Feb 13, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem. labels Feb 13, 2019
vsemozhetbyt
vsemozhetbyt reviewed Feb 13, 2019
View reviewed changes
Comment threaddoc/api/repl.md Outdated
@richardlau

richardlau commented Feb 13, 2019

Copy link
Copy Markdown
Member

There are other instances in this file of the repl being started from the command line (node ...) and they're currently using js. Either all of them should be changed for consistency or the instance being changed here left alone.

@vsemozhetbyt

vsemozhetbyt commented Feb 13, 2019

Copy link
Copy Markdown
Contributor

It seems they were marked as js so that code and outputted literals are js-highlighted.

@gengjiawen

gengjiawen commented Feb 14, 2019

Copy link
Copy Markdown
MemberAuthor

It's not js actually. So better to change it.

lance
lance reviewed Feb 14, 2019
View reviewed changes

@lancelance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how changing the code sections to bash is an improvement. It's not pure JavaScript since it's in the REPL, but it seems closer to JS than to bash, in my opinion. If we're going to be strict about it, I would say that in most code examples on this file, there should be no language specified.

@gengjiawen

gengjiawen commented Feb 14, 2019

Copy link
Copy Markdown
MemberAuthor

Refactor it to console, inspired by https://stackoverflow.com/a/49004070/1713757.

@danbev

danbev commented Feb 19, 2019

Copy link
Copy Markdown
Contributor

CI lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2664/

@danbev

danbev commented Feb 19, 2019

Copy link
Copy Markdown
Contributor

Landed in a993160.

@danbevdanbev closed this Feb 19, 2019
danbev pushed a commit that referenced this pull request Feb 19, 2019
@gengjiawen@danbev
doc: fix code lang in repl.md
a993160
PR-URL: #26075
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 19, 2019
@gengjiawen@addaleax
doc: fix code lang in repl.md
db9ec5a
PR-URL: #26075
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeARBridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@gengjiawen@rvagg
doc: fix code lang in repl.md
8fac54a
PR-URL: #26075
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@vsemozhetbytvsemozhetbytvsemozhetbyt left review comments
@lancelancelance approved these changes
@danbevdanbevdanbev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.replIssues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gengjiawen@richardlau@vsemozhetbyt@danbev@lance@nodejs-github-bot