Skip to content

worker: use fake MessageEvent for port.onmessage - #26082

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-onmessage-messageevent
Closed

worker: use fake MessageEvent for port.onmessage#26082
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-onmessage-messageevent

Conversation

@addaleax

@addaleaxaddaleax commented Feb 13, 2019

Copy link
Copy Markdown
Member

Instead of passing the payload for Workers directly to .onmessage,
perform something more similar to what the browser API provides,
namely create an event object with a .data property.

This does not make MessagePort implement the EventTarget API, nor
does it implement the full MessageEvent API, but it would make
such extensions non-breaking changes if we desire them at
some point in the future.

(This would be a breaking change if Workers were not experimental.
Currently, this method is also undocumented and only exists with
the idea of enabling some degree of Web compatibility.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
worker: use fake MessageEvent for port.onmessage
1a0418a
Instead of passing the payload for Workers directly to `.onmessage`,
perform something more similar to what the browser API provides,
namely create an event object with a `.data` property.
This does not make `MessagePort` implement the `EventTarget` API, nor
does it implement the full `MessageEvent` API, but it would make
such extensions non-breaking changes if we desire them at
some point in the future.
(This would be a breaking change if Workers were not experimental.
Currently, this method is also undocumented and only exists with
the idea of enabling some degree of Web compatibility.)
@nodejs-github-bot

nodejs-github-bot commented Feb 13, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2593/pipeline

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support. labels Feb 13, 2019
@addaleax

addaleax commented Feb 13, 2019

Copy link
Copy Markdown
MemberAuthor

/cc @nodejs/workers @surma

lundibundi
lundibundi reviewed Feb 14, 2019
View reviewed changes
Comment threadsrc/node_messaging.cc
@surma

surma commented Feb 14, 2019

Copy link
Copy Markdown

I can't comment much on the implementation, but I'm very supportive of the event-ish object for easier web interop and future-proofing the API.

Thanks for doing this, @addaleax!

@addaleax

addaleax commented Feb 14, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/20782/ (:heavy_check_mark:)

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 15, 2019
@addaleax

addaleax commented Feb 15, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 5adda2c

@addaleax
addaleax deleted the worker-onmessage-messageevent branch February 15, 2019 22:21
addaleax added a commit that referenced this pull request Feb 15, 2019
@addaleax
worker: use fake MessageEvent for port.onmessage
5adda2c
Instead of passing the payload for Workers directly to `.onmessage`,
perform something more similar to what the browser API provides,
namely create an event object with a `.data` property.
This does not make `MessagePort` implement the `EventTarget` API, nor
does it implement the full `MessageEvent` API, but it would make
such extensions non-breaking changes if we desire them at
some point in the future.
(This would be a breaking change if Workers were not experimental.
Currently, this method is also undocumented and only exists with
the idea of enabling some degree of Web compatibility.)
PR-URL: #26082
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
addaleax added a commit that referenced this pull request Feb 16, 2019
@addaleax
worker: use fake MessageEvent for port.onmessage
a99bf1d
Instead of passing the payload for Workers directly to `.onmessage`,
perform something more similar to what the browser API provides,
namely create an event object with a `.data` property.
This does not make `MessagePort` implement the `EventTarget` API, nor
does it implement the full `MessageEvent` API, but it would make
such extensions non-breaking changes if we desire them at
some point in the future.
(This would be a breaking change if Workers were not experimental.
Currently, this method is also undocumented and only exists with
the idea of enabling some degree of Web compatibility.)
PR-URL: #26082
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@BridgeARBridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@addaleax@rvagg
worker: use fake MessageEvent for port.onmessage
77a944c
Instead of passing the payload for Workers directly to `.onmessage`,
perform something more similar to what the browser API provides,
namely create an event object with a `.data` property.
This does not make `MessagePort` implement the `EventTarget` API, nor
does it implement the full `MessageEvent` API, but it would make
such extensions non-breaking changes if we desire them at
some point in the future.
(This would be a breaking change if Workers were not experimental.
Currently, this method is also undocumented and only exists with
the idea of enabling some degree of Web compatibility.)
PR-URL: #26082
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 5, 2019
@BridgeAR
2019-03-06, Version 11.11.0 (Current)
3c277d7
Notable Changes
* n-api:
* Implement date object (Jarrod Connolly)
#25917
* util:
* Add compact depth mode for `util.inspect()` (Ruben Bridgewater)
#26269
* worker:
* Improve integration with native addons (Anna Henningsen)
#26175
* MessagePort.prototype.onmessage takes arguments closer to the Web
specification now (Anna Henningsen)
#26082
Trott pushed a commit to Trott/io.js that referenced this pull request Mar 6, 2019
@BridgeAR
2019-03-06, Version 11.11.0 (Current)
b22ee71
Notable Changes
* n-api:
* Implement date object (Jarrod Connolly)
nodejs#25917
* util:
* Add compact depth mode for `util.inspect()` (Ruben Bridgewater)
nodejs#26269
* worker:
* Improve integration with native addons (Anna Henningsen)
nodejs#26175
* MessagePort.prototype.onmessage takes arguments closer to the Web
specification now (Anna Henningsen)
nodejs#26082
@julienwjulienw mentioned this pull request Mar 22, 2019
Closed
@julienw

julienw commented Mar 22, 2019

Copy link
Copy Markdown

hey @addaleax, it seems that this changes the api when calling postMessage on the worker instance (and so onmessage inside the worker), but I don't see it changes the other way, when calling postMessage from inside the worker and getting the result in onmessage on the worker instance. Is it expected? Do you have any plan to implement this change as well?

This was referenced Mar 22, 2019
Open
Closed
@surma

surma commented Mar 22, 2019

Copy link
Copy Markdown

@julienw I just filed #26856 for that :)

@julienw

julienw commented Mar 22, 2019

Copy link
Copy Markdown

Ah I realize that in our code we use on('message', handler), and not onmessage indeed. But the general comment about implementing the structure { data: XXX } still applies :)

@UziTech

UziTech commented Mar 26, 2019

Copy link
Copy Markdown
Contributor

Just to make it clear, this changes the info passed to port.onmessage to an object with a .data property, but does not change the info passed to port.on('message')?

@addaleax

addaleax commented Mar 26, 2019

Copy link
Copy Markdown
MemberAuthor

Just to make it clear, this changes the info passed to port.onmessage to an object with a .data property, but does not change the info passed to port.on('message')?

Yes, exactly.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
+2 more reviewers
@devsnekdevsnekdevsnek approved these changes
@lundibundilundibundilundibundi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@addaleax@nodejs-github-bot@surma@julienw@UziTech@jasnell@devsnek@lundibundi