Uh oh!
There was an error while loading. Please reload this page.
inspector: forward errors from InspectorConsoleCall - #26113
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Do not assume that entering JS cannot fail.
addaleaxforce-pushed
the
inspector-call
branch
from
February 14, 2019 22:59
943016f to
777d809Comparejoyeecheung
approved these changes
Feb 14, 2019
joyeecheung
left a comment
Member
There was a problem hiding this comment.
LGTM. I wonder if we can use something other than an v8::Object for this, though.
eugeneo
approved these changes
Feb 14, 2019
JungMinu
approved these changes
Feb 15, 2019
MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/20786/ (:heavy_check_mark:) |
jasnell
approved these changes
Feb 15, 2019
addaleax
commented
Feb 17, 2019
MemberAuthor
Landed in 009efd0 |
addaleax added a commit
that referenced
this pull request
Feb 17, 2019
Do not assume that entering JS cannot fail. PR-URL: #26113 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2 tasks
addaleax added a commit
that referenced
this pull request
Feb 17, 2019
Do not assume that entering JS cannot fail. PR-URL: #26113 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
rvagg pushed a commit
that referenced
this pull request
Feb 28, 2019
Do not assume that entering JS cannot fail. PR-URL: #26113 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not assume that entering JS cannot fail.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes