Skip to content

src: remove invalid casts in options parser - #26139

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:ubsan-1
Closed

src: remove invalid casts in options parser#26139
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:ubsan-1

Conversation

@addaleax

@addaleaxaddaleax commented Feb 15, 2019

Copy link
Copy Markdown
Member

Fixes: #26131

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Feb 15, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2626/pipeline

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 15, 2019
@addaleaxaddaleax mentioned this pull request Feb 15, 2019
Closed
@addaleax

addaleax commented Feb 16, 2019

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/20811/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2019
@addaleax

addaleax commented Feb 16, 2019

Copy link
Copy Markdown
MemberAuthor

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20820/

@addaleax

addaleax commented Feb 18, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 35e6070

@addaleax
addaleax deleted the ubsan-1 branch February 18, 2019 08:15
addaleax added a commit that referenced this pull request Feb 18, 2019
@addaleax
src: remove invalid casts in options parser
35e6070
Fixes: #26131
PR-URL: #26139
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax added a commit that referenced this pull request Feb 18, 2019
@addaleax
src: remove invalid casts in options parser
9524ac4
Fixes: #26131
PR-URL: #26139
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@BridgeARBridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@addaleax@rvagg
src: remove invalid casts in options parser
778db67
Fixes: #26131
PR-URL: #26139
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheungjoyeecheungjoyeecheung approved these changes
@JungMinuJungMinuJungMinu approved these changes
+1 more reviewer
@hashseedhashseedhashseed approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Undefined Behavior sanitizer: downcast is undefined behavior

5 participants

@addaleax@nodejs-github-bot@hashseed@joyeecheung@JungMinu