tls: TLSSocket options not initialized by jhamhader · Pull Request #2614 · nodejs/node

jhamhader · 2015-08-29T21:56:40Z

Upon creating a TLSSocket object without options, default options will be used, which
set the socket as isServer: false
Updated tls docs and added test-tls-socket-default-options

See issue #2394

mscdex · 2015-08-29T22:50:45Z

The true here should include backticks also for consistency.

thefourtheye · 2015-08-31T07:30:05Z

If isServer is not set explicitly then it will be undefined. Does the code really check if the value is false anywhere?

Edit: I see that the code relies only on the truthiness/falsiness of isServer.

indutny · 2015-09-24T17:04:29Z

cc @nodejs/crypto

indutny · 2015-09-24T17:12:31Z

I don't think that this can possibly suffice. There are also context and various other things that needs to be specified. It can't be possible to omit them, so I don't think that there is any point in providing this default values.

If you would like to make isServerfalse by default - let's do it explicitly!

I'll make isServer: false by default (set to false if options is undefined or options.isServer is undefined).
Regarding the context - TLS API says the rest of the options (besides isServer) are optional and seems like _wrapHandle() creates a secureContext if such is not provided.

Oh... sorry then!

jhamhader · 2015-09-26T20:03:12Z

Changed isServer to be false by default
Updated test to include two kinds of arguments of TLSSocket()

jhamhader · 2015-10-08T18:30:06Z

@indutny can you confirm?

indutny · 2015-10-13T16:48:54Z

Why is it needed? Would it be enough to do !!isServer when passing it to the C++ layer?

jhamhader · 2015-10-18T19:05:49Z

Well, it is not only passed to the C++ layer - it is also used extensively in _tls_wrap.js.
Instead of the current change, we could do in TLSSocket():

this._tlsOptions.isServer = !!options.isServer

but initializing this value with a default boolean (in either way) seems like a harmless and safe thing to do.

indutny · 2015-10-18T19:10:50Z

@jhamhader It feels like doing !! in one place is simpler.

jhamhader · 2015-10-20T19:08:59Z

Done

indutny · 2015-10-20T19:11:20Z

Is this over 80 column limit?

Thanks for the thorough review. Fixed that

Upon creating a TLSSocket object, set the default isServer option to false Updated tls docs and added test-tls-socket-default-options

indutny · 2015-10-20T19:36:55Z

LGTM

indutny · 2015-10-20T19:38:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/543/

indutny · 2015-10-20T20:14:49Z

Landed in adfd20b, thank you!

Upon creating a TLSSocket object, set the default isServer option to false Updated tls docs and added test-tls-socket-default-options PR-URL: #2614 Reviewed-By: Fedor Indutny <fedor@indutny.com>

MylesBorins · 2015-10-23T18:52:42Z

LTS?

MylesBorins · 2015-10-23T18:52:51Z

/cc @jasnell

Upon creating a TLSSocket object, set the default isServer option to false Updated tls docs and added test-tls-socket-default-options PR-URL: nodejs#2614 Reviewed-By: Fedor Indutny <fedor@indutny.com>

jasnell · 2015-10-26T16:53:18Z

Landed in v4.x-staging in 590378c

Upon creating a TLSSocket object, set the default isServer option to false Updated tls docs and added test-tls-socket-default-options PR-URL: #2614 Reviewed-By: Fedor Indutny <fedor@indutny.com>

targos added the tls Issues and PRs related to the tls subsystem. label Aug 29, 2015

mscdex reviewed Aug 29, 2015
View reviewed changes

rvagg force-pushed the master branch from 11c25c2 to ba02bd0Compare September 6, 2015 11:55

jhamhader force-pushed the tls-socket-default-options branch 2 times, most recently from 9fc32cd to f61c44aCompare September 19, 2015 12:17

indutny reviewed Sep 24, 2015
View reviewed changes

jhamhader force-pushed the tls-socket-default-options branch from f61c44a to 324bb28Compare September 26, 2015 20:01

jhamhader force-pushed the tls-socket-default-options branch from 324bb28 to 7f69c59Compare October 20, 2015 19:06

indutny reviewed Oct 20, 2015
View reviewed changes

tls: TLSSocket options default isServer false
62354f6
Upon creating a TLSSocket object, set the default isServer option to false Updated tls docs and added test-tls-socket-default-options

jhamhader force-pushed the tls-socket-default-options branch from 7f69c59 to 62354f6Compare October 20, 2015 19:33

indutny closed this Oct 20, 2015

rvagg mentioned this pull request Oct 21, 2015
Release proposal: v5.0.0 #3466
Merged

jhamhader mentioned this pull request Oct 21, 2015
tls: TLSSocket options not initialized #2394
Closed

jasnell added the lts-watch-v4.x label Oct 24, 2015

jasnell added the land-on-v4.x label Oct 24, 2015

jasnell removed the lts-watch-v4.x label Oct 26, 2015

rvagg mentioned this pull request Oct 28, 2015
Preparing v4.2.2 LTS Maintenance nodejs/Release#50
Closed

jasnell mentioned this pull request Oct 29, 2015
Release Proposal: v4.2.2 "Argon" (LTS) #3588
Closed

jasnell removed the land-on-v4.x label Nov 3, 2015

Uh oh!

Uh oh!

Conversation

jhamhader commented Aug 29, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thefourtheye commented Aug 31, 2015

Uh oh!

indutny commented Sep 24, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jhamhader commented Sep 26, 2015

Uh oh!

jhamhader commented Oct 8, 2015

Uh oh!

indutny commented Oct 13, 2015

Uh oh!

jhamhader commented Oct 18, 2015

Uh oh!

indutny commented Oct 18, 2015

Uh oh!

jhamhader commented Oct 20, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

indutny commented Oct 20, 2015

Uh oh!

indutny commented Oct 20, 2015

Uh oh!

indutny commented Oct 20, 2015

Uh oh!

MylesBorins commented Oct 23, 2015

Uh oh!

MylesBorins commented Oct 23, 2015

Uh oh!

jasnell commented Oct 26, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants