Skip to content

tools: update ESLint to 5.14.0 - #26142

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:eslint
Feb 18, 2019
Merged

tools: update ESLint to 5.14.0#26142
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:eslint

Conversation

@cjihrig

@cjihrigcjihrig commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Update ESLint to 5.14.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Feb 15, 2019

Copy link
Copy Markdown
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2629/pipeline

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 15, 2019
Trott
Trott approved these changes Feb 15, 2019
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 15, 2019
@cjihrig
tools: update ESLint to 5.14.0
77b39c2
Update ESLint to 5.14.0
PR-URL: nodejs#26142
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
@cjihrig

cjihrig commented Feb 18, 2019

Copy link
Copy Markdown
ContributorAuthor

Green CI: https://ci.nodejs.org/job/node-test-pull-request/20847/

@cjihrig
cjihrig merged commit 77b39c2 into nodejs:masterFeb 18, 2019
@cjihrig
cjihrig deleted the eslint branch February 18, 2019 02:58
addaleax pushed a commit that referenced this pull request Feb 18, 2019
@cjihrig@addaleax
tools: update ESLint to 5.14.0
19fadd8
Update ESLint to 5.14.0
PR-URL: #26142
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
@BridgeARBridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@cjihrig@rvagg
tools: update ESLint to 5.14.0
28d6074
Update ESLint to 5.14.0
PR-URL: #26142
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Wyatt Preul <wpreul@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
+1 more reviewer
@geekgeekgeek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cjihrig@nodejs-github-bot@geek@Trott