Skip to content

meta: remove the useless GitHub Account - #26146

Closed
ghost wants to merge 3 commits into
masterfrom
unknown repository
Closed

meta: remove the useless GitHub Account#26146
ghost wants to merge 3 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghostghost commented Feb 16, 2019•
edited by ghost
Loading

Copy link
Copy Markdown

Due to maledong_private@qq.com is useless because I cannot log in
with the email address (GitHub doesn't support qq mail well),
and I've successfully changed my email account to maledong_github@outlook.com
instead. So I removed my old useless email address and keep the new one
for the same account 'MaleDong', because there're two 'MaleDong' Accounts and
they are both pointing to me.

Here're the images:
email

profiles

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 16, 2019
@ZYSzys

ZYSzys commented Feb 16, 2019

Copy link
Copy Markdown
Member

AFAIK, this file was generated by tools/update-authors.js and stat from git log.

node/AUTHORS

Line 2321 in e74019f

# Generated by tools/update-authors.js

Seems not suitable to change manually 🤔.(Please correct me if I'm wrong)

@ghostghost changed the title chore: remove the useless GitHub Accountmeta: remove the useless GitHub AccountFeb 16, 2019
richardlau
richardlau requested changes Feb 16, 2019
View reviewed changes

@richardlaurichardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As has been pointed out, AUTHORS is generated by tooling, so if you remove the entry manually it's just going to be readded the next time the tool is run based on your previous commits.

What you should do instead is edit .mailmap and map your old email address to your current one.

@ghost

ghost commented Feb 16, 2019

Copy link
Copy Markdown
Author

@richardlau：Thanks! I've added my own email account address into the map file, because I didn't find it yet.

MaleDong
meta: remove the useless GitHub Account
1bc4cd3
Due to `maledong_private@qq.com` is useless because I cannot log
in with the email address (GitHub doesn't support `qq` mail well),
and I've successfully changed my email account to
`maledong_github@outlook.com` instead.
So I removed my old useless email address and keep the new
one for the same account 'MaleDong', because there're two
'MaleDong' Accounts and they are both pointing to me.
The final solution is that to add my own email account address
into the '.mailmap' to let AUTHORS re-generated.
richardlau
richardlau reviewed Feb 17, 2019
View reviewed changes
Comment thread.mailmap Outdated
@jasnell

jasnell commented Feb 18, 2019

Copy link
Copy Markdown
Member

The AUTHORS file can be manually changed and often is when we generated it. Making this edit is fine, we'll just have to make sure the change is not undone later ;-)

Maledong
fix: remove useless email account
a05923c
remove useless email account in `AUTHOR` so as to keep the file in union with `.mailmap`
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2019
@BridgeAR

BridgeAR commented Feb 20, 2019

Copy link
Copy Markdown
Member

There is no linter for this, so running a CI won't make any sense in this case.

@addaleax

addaleax commented Mar 1, 2019

Copy link
Copy Markdown
Member

Landed in 43cb36b

@addaleaxaddaleax closed this Mar 1, 2019
addaleax pushed a commit that referenced this pull request Mar 1, 2019
MaleDong@addaleax
meta: remove the useless GitHub Account
43cb36b
Due to `maledong_private@qq.com` is useless because I cannot log
in with the email address (GitHub doesn't support `qq` mail well),
and I've successfully changed my email account to
`maledong_github@outlook.com` instead.
So I removed my old useless email address and keep the new
one for the same account 'MaleDong', because there're two
'MaleDong' Accounts and they are both pointing to me.
The final solution is that to add my own email account address
into the '.mailmap' to let AUTHORS re-generated.
PR-URL: #26146
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@ghost
ghost deleted the RemoveUselessEmailAccount branch March 1, 2019 10:14
@ghost

ghost commented Mar 1, 2019

Copy link
Copy Markdown
Author

Thanks all!

addaleax pushed a commit that referenced this pull request Mar 1, 2019
MaleDong@addaleax
meta: remove the useless GitHub Account
6d014a6
Due to `maledong_private@qq.com` is useless because I cannot log
in with the email address (GitHub doesn't support `qq` mail well),
and I've successfully changed my email account to
`maledong_github@outlook.com` instead.
So I removed my old useless email address and keep the new
one for the same account 'MaleDong', because there're two
'MaleDong' Accounts and they are both pointing to me.
The final solution is that to add my own email account address
into the '.mailmap' to let AUTHORS re-generated.
PR-URL: #26146
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeARBridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZYSzys@jasnell@BridgeAR@addaleax@richardlau@nodejs-github-bot