Skip to content

src: apply clang-tidy rule modernize-deprecated-headers - #26159

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:clang-tidy-deprecated-headers
Closed

src: apply clang-tidy rule modernize-deprecated-headers#26159
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:clang-tidy-deprecated-headers

Conversation

@gengjiawen

@gengjiawengengjiawen commented Feb 17, 2019•
edited
Loading

Copy link
Copy Markdown
Member

The rule link: https://clang.llvm.org/extra/clang-tidy/checks/modernize-deprecated-headers.html.

Summary

Some headers from C library were deprecated in C++ and are no longer welcome in C++ codebases. Some have no effect in C++. For more details refer to the C++ 14 Standard [depr.c.headers] section.

This check replaces C standard library headers with their C++ alternatives and removes redundant ones.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Feb 17, 2019
@gengjiawen
gengjiawenforce-pushed the clang-tidy-deprecated-headers branch from 2385f21 to 7b6569fCompareFebruary 17, 2019 04:50
@gengjiawen

gengjiawen commented Feb 17, 2019

Copy link
Copy Markdown
MemberAuthor

Revert js_native_* seems they are used as c source file.

TimothyGu
TimothyGu reviewed Feb 17, 2019
View reviewed changes
Comment threadsrc/node_os.cc Outdated
@gengjiawen
gengjiawenforce-pushed the clang-tidy-deprecated-headers branch from 7b6569f to 7cf651dCompareFebruary 17, 2019 10:44
@gengjiawen

gengjiawen commented Feb 18, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@addaleax@jasnell@cjihrig Can you review this ? thanks.

@danbev

danbev commented Feb 20, 2019

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/20898/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 20, 2019
@danbev

danbev commented Feb 22, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Re-run of failing node-test-commit-linuxone (✔️)

@gengjiawen

gengjiawen commented Feb 27, 2019

Copy link
Copy Markdown
MemberAuthor

@danbev@addaleax Can you import the change ? thanks.

@danbev

danbev commented Feb 27, 2019

Copy link
Copy Markdown
Contributor

Landed in 8137668.

@danbevdanbev closed this Feb 27, 2019
danbev pushed a commit that referenced this pull request Feb 27, 2019
@gengjiawen@danbev
src: apply clang-tidy rule modernize-deprecated-headers
8137668
PR-URL: #26159
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gengjiawen

gengjiawen commented Feb 27, 2019

Copy link
Copy Markdown
MemberAuthor

thanks.

@gengjiawen
gengjiawen deleted the clang-tidy-deprecated-headers branch February 27, 2019 07:40
@gengjiawengengjiawen mentioned this pull request Feb 27, 2019
Merged
3 tasks
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@gengjiawen@addaleax
src: apply clang-tidy rule modernize-deprecated-headers
8b515b2
PR-URL: #26159
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
+2 more reviewers
@TimothyGuTimothyGuTimothyGu left review comments
@danbevdanbevdanbev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gengjiawen@danbev@jasnell@TimothyGu@BridgeAR@nodejs-github-bot