Skip to content

test: fix flaky test-worker-ref-onexit - #26170

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:fix-worker-ref-on-exit
Closed

test: fix flaky test-worker-ref-onexit#26170
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:fix-worker-ref-on-exit

Conversation

@addaleax

@addaleaxaddaleax commented Feb 17, 2019•
edited
Loading

Copy link
Copy Markdown
Member

This was very flaky on AIX (over 10 % failure rate).

Stress test for this PR: https://ci.nodejs.org/job/node-stress-single-test/2158/ (0/359 failures – definitely better than 10 % :))
CI: https://ci.nodejs.org/job/node-test-commit/25940/

Please 👍 this comment to approve fast-tracking.

Fixes: #26167

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleaxaddaleax added test Issues and PRs related to the tests. flaky-test Issues and PRs related to the tests with unstable failures on the CI. worker Issues and PRs related to Worker support. labels Feb 17, 2019
@nodejs-github-bot

nodejs-github-bot commented Feb 17, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2645/pipeline

@addaleaxaddaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 17, 2019
@addaleax

addaleax commented Feb 17, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in 2da7ff5

@addaleax
addaleax deleted the fix-worker-ref-on-exit branch February 17, 2019 23:11
addaleax added a commit that referenced this pull request Feb 17, 2019
@addaleax
test: fix flaky test-worker-ref-onexit
2da7ff5
Fixes: #26167
PR-URL: #26170
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
addaleax added a commit that referenced this pull request Feb 18, 2019
@addaleax
test: fix flaky test-worker-ref-onexit
ebdc16e
Fixes: #26167
PR-URL: #26170
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BridgeARBridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@addaleax@rvagg
test: fix flaky test-worker-ref-onexit
441b545
Fixes: #26167
PR-URL: #26170
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.flaky-testIssues and PRs related to the tests with unstable failures on the CI.testIssues and PRs related to the tests.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate flaky test-worker-ref-onexit

6 participants

@addaleax@nodejs-github-bot@Trott@lpinca@richardlau@BethGriggs