Uh oh!
There was an error while loading. Please reload this page.
test: increase run time in test-worker-prof - #26172
Closed
addaleax wants to merge 2 commits into
Closed
Conversation
This test has occasionally been failing on Windows since it was added, with 6 instead of 15 ticks being seen. Increasing the duration of the test should make it more reliable.
lpinca
approved these changes
Feb 17, 2019
Uh oh!
There was an error while loading. Please reload this page.
danbev
approved these changes
Feb 18, 2019
danbev
commented
Feb 18, 2019
Contributor
jasnell
approved these changes
Feb 18, 2019
BridgeAR
approved these changes
Feb 20, 2019
addaleax
commented
Feb 20, 2019
MemberAuthor
Landed in fab0668 |
addaleax added a commit
that referenced
this pull request
Feb 20, 2019
This test has occasionally been failing on Windows since it was added, with 6 instead of 15 ticks being seen. Increasing the duration of the test should make it more reliable. PR-URL: #26172 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax added a commit
that referenced
this pull request
Feb 21, 2019
This test has occasionally been failing on Windows since it was added, with 6 instead of 15 ticks being seen. Increasing the duration of the test should make it more reliable. PR-URL: #26172 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
rvagg pushed a commit
that referenced
this pull request
Feb 28, 2019
This test has occasionally been failing on Windows since it was added, with 6 instead of 15 ticks being seen. Increasing the duration of the test should make it more reliable. PR-URL: #26172 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test has occasionally been failing on Windows since it
was added, with 6 instead of 15 ticks being seen.
Increasing the duration of the test should make it more reliable.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes