Uh oh!
There was an error while loading. Please reload this page.
src: Make node::SignalWrap::OnSignal into a lambda - #26184
Merged
Conversation
gireeshpunathilforce-pushed
the
signal_lambda
branch
from
February 18, 2019 14:29
caa3b69 to
deeca8cCompareaddaleax
approved these changes
Feb 18, 2019
cjihrig
approved these changes
Feb 18, 2019
jasnell
approved these changes
Feb 18, 2019
gireeshpunathil
commented
Feb 20, 2019
MemberAuthor
PR-URL: nodejs#26184 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gireeshpunathilforce-pushed
the
signal_lambda
branch
from
February 21, 2019 14:57
deeca8c to
dbfe14cComparegireeshpunathil
commented
Feb 21, 2019
MemberAuthor
landed as dbfe14c |
addaleax pushed a commit
that referenced
this pull request
Feb 21, 2019
PR-URL: #26184 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
rvagg pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #26184 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes